Bug #34050
DatetimeParser code documentation is wrong
| Status: | Resolved | Start date: | 2012-02-17 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | I18n | |||
| Target version: | TYPO3 Flow Base Distribution - 1.1 RC1 | |||
| PHP Version: | Complexity: | |||
| Has patch: | No | Affected Flow version: | FLOW3 1.0.0 |
Description
The public methods expect a DateTime object, which they then forward as a string to the internal methods, which then break when using substr on a DateTime object.
Associated revisions
[BUGFIX] DateTimeValidator throws exception when validating DateTime objects
The DateTimeValidator tries to parse DateTime objects
with the L18n DatesParser which throws an exception.
This change fixes this by checking if the specified value
is an instance of DateTime first.
Change-Id: Iefa37bf90dca7b8393b830436278fe32e71c03e8
Related: #34050
[BUGFIX] Fix code documentation of DatetimeParser
The parser code documentation would state the parse methods
expect \DateTime instances, but in fact strings are expected.
Change-Id: Ice12929ada2562919da29e3d10a712d45a7021a6
Fixes: #34050
Releases: 1.0, 1.1, 1.2
[BUGFIX] Fix code documentation of DatetimeParser
The parser code documentation would state the parse methods
expect \DateTime instances, but in fact strings are expected.
Change-Id: Ice12929ada2562919da29e3d10a712d45a7021a6
Fixes: #34050
Releases: 1.0, 1.1, 1.2
[BUGFIX] Fix code documentation of DatetimeParser
The parser code documentation would state the parse methods
expect \DateTime instances, but in fact strings are expected.
Change-Id: Ice12929ada2562919da29e3d10a712d45a7021a6
Fixes: #34050
Releases: 1.0, 1.1, 1.2
History
#1 Updated by Kira Backes over 3 years ago
This also causes the DateTimeValidator to not work
#2 Updated by Karsten Dambekalns over 3 years ago
- Category set to I18n
- Status changed from New to Accepted
- Assigned To set to Karsten Dambekalns
- Target version set to 1.1
#3 Updated by Bastian Waidelich over 3 years ago
Please check, if https://review.typo3.org/#/c/10070/ already fixes this for you
#4 Updated by Karsten Dambekalns about 3 years ago
- Target version changed from 1.1 to 1.1 RC1
#5 Updated by Karsten Dambekalns about 3 years ago
- Subject changed from DatetimeParser does not work to DatetimeParser code documentation is wrong
- Affected Flow version changed from Git master to FLOW3 1.0.0
The code behaves correctly, but the code documentation is wrong - the parser expects strings to parse, in all methods.
#6 Updated by Gerrit Code Review about 3 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12364
#7 Updated by Gerrit Code Review about 3 years ago
Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12373
#8 Updated by Gerrit Code Review about 3 years ago
Patch set 1 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/12374
#9 Updated by Karsten Dambekalns about 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 7024268cd8cd45394aa764ba9f45a759f0629b2d.