Feature #34185
SignalSlot Dispatcher should check if Slot method is declared static and act accordingly
| Status: | Resolved | Start date: | 2012-02-22 | |
|---|---|---|---|---|
| Priority: | Could have | Due date: | ||
| Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | SignalSlot | |||
| Target version: | - | |||
| PHP Version: | Complexity: | |||
| Has patch: | No |
Description
Currently if you connect a $classname + $methodname as slot it will instantiate the class to call $methodname on the instance, even if the method is declared static. I think it wouldn't be a problem to call it static in this case to avoid problems with class instances that shouldn't be there normally.
Associated revisions
[FEATURE] Makes it possible to wire signals to static slots
To use a static slot simply prefix the slot method name with ::
Change-Id: I6d7bd963551342abb4c5bcd686ccdaff52196986
Resolves: #34185
Releases: 1.1
History
#1 Updated by Gerrit Code Review over 3 years ago
- Status changed from Accepted to Under Review
#2 Updated by Karsten Dambekalns over 3 years ago
- Status changed from Under Review to Accepted
- Assigned To set to Karsten Dambekalns
#3 Updated by Gerrit Code Review over 3 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9622
#4 Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9622
#5 Updated by Gerrit Code Review over 3 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9622
#6 Updated by Gerrit Code Review over 3 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9622
#7 Updated by Gerrit Code Review about 3 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9622
#8 Updated by Karsten Dambekalns about 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 00ea79198668b30e3fefbd277f8070965ff83c18.