Bug #34186

Setting a value always resets the field on mapping errors

Added by Kira Backes over 3 years ago. Updated 5 months ago.

Status:Closed Start date:2012-02-22
Priority:Should have Due date:
Assigned To:Bastian Waidelich % Done:

0%
Category:ViewHelpers
Target version:-
Has patch:No Affected Flow version:Git 1.0

Description

If I set a value on any field of the form it gets reset every time there
is a mapping error, so the user has to reenter the field every time.

Could easily be fixed by changing the order of the if-clause in
\TYPO3\Fluid\ViewHelpers\Form\AbstractFormFieldViewHelper::getValue

Related issues

duplicated by TYPO3.Fluid - Bug #47363: Error Classes are only set for form fields in object context Closed 2013-04-18

History

#1 Updated by Kira Backes over 3 years ago

Okay, it’s not that easy to just change the if-else order, then submit buttons disappear.. I guess we need another attribute for a start value like that or we only use the submitted form data if it is not NULL.

#2 Updated by Bastian Waidelich over 3 years ago

Hi Kira,

Please provide more information. Did you use one of the form viewhelpers (which one?) and bind it to a property of the form object? Can you provide some (fluid) code snippets?

#3 Updated by Bastian Waidelich over 3 years ago

  • Status changed from New to Needs Feedback

#4 Updated by Sebastian Kurfuerst over 3 years ago

  • Status changed from Needs Feedback to Accepted
  • Assigned To set to Sebastian Kurfuerst

OK; the automatic fill-in does is partly broken when not using object accessor mode.

Fix is underway.

#5 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10732

#6 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10733

#7 Updated by Bastian Waidelich almost 2 years ago

  • Category set to ViewHelpers
  • Assigned To changed from Sebastian Kurfuerst to Bastian Waidelich

The mentioned review (http://review.typo3.org/10733) does not fix this. I'll take care asap

#8 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24794

#9 Updated by Bastian Waidelich 5 months ago

  • Status changed from Under Review to Closed

Truly sorry for the huge delay, this was a tricky one (because it is a breaking behavior).. But I just moved this to https://jira.typo3.org/browse/FLOW-213 and take care of it right now

Also available in: Atom PDF