Bug #34233

Shortcut Handling in FrontendNodeRoutePartHandler can lead to exception

Added by Christian Müller over 3 years ago. Updated over 3 years ago.

Status:Resolved Start date:2012-02-24
Priority:Must have Due date:
Assigned To:Christian Müller % Done:

100%

Category:-
Target version:-

Description

resolveValue in FrontendNodeRoutePartHandler doesn't check if $node is really instance of NodeInterface, it just calls methods on it. This leads to unhandled exceptions in vanilla Phoenix Distribution.

To test checkout clean Pheonix master, import, create admin and login, you should directly end up with the exception.

Associated revisions

Revision 2790fdb5
Added by Christian Müller over 3 years ago

[BUGFIX] Check if resolved node is instance of NodeInterface

Currently resolveValue assumes that the resolved node is really
a node and calls node methods without checking if that really is
possible. This change fixes that behaviour.

Change-Id: I8cb07388fa61128f48c3a3e14f21f70d2e3e6d6a
Fixes: #34233

History

#1 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9182

#2 Updated by Sebastian Kurfuerst over 3 years ago

  • Status changed from Accepted to Resolved
  • % Done changed from 0 to 100

thanks :)

Also available in: Atom PDF