Bug #35059
Default for nullable is TRUE but should be FALSE
Status: | Resolved | Start date: | 2012-03-20 | |
---|---|---|---|---|
Priority: | Should have | Due date: | ||
Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
Category: | Persistence | |||
Target version: | TYPO3 Flow Base Distribution - 1.1 | |||
PHP Version: | Complexity: | |||
Has patch: | No | Affected Flow version: | Git master |
Description
The nullable option for columns is FALSE in Doctrine 2 unless otherwise indicated. Our annotation driver uses a default of TRUE, which breaks the intended alignment of behavior between vanilla Doctrine 2 and the FLOW3 integration.
Associated revisions
[!!!][BUGFIX] Changes the default for nullable columns to FALSE
This change makes columns not nullable by default, as is the case with
vanilla Doctrine 2.
This is a breaking change if you rely on NULL values to be returned
to detect special cases, like for not using unset date properties.
In those cases you need to mark your property with the Doctrine
annotation: Column(nullable=true)
Change-Id: I9537b222a0376cf87c0e547c662b90ccb1532866
Fixes: #35059
Releases: 1.1
History
#1 Updated by Gerrit Code Review over 3 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9774
#2 Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9774
#3 Updated by Gerrit Code Review over 3 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9774
#4 Updated by Gerrit Code Review over 3 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9774
#5 Updated by Karsten Dambekalns over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 115bda50778c04619481554a94bf5b47ab98409b.