Bug #35736
Fix Handling of CurrentNode
| Status: | Resolved | Start date: | 2012-04-06 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Christian Müller | % Done: | 100% |
|
| Category: | - | |||
| Target version: | - |
Description
The context holds a currentNode property which is set in the TYPO3.TYPO3 NodeController and used in Typoscript rendering. This is dangerous as the context is not a singleton and can be overriden due to treatNodesWithContext() for example in link generation. After that the currentNode is lost. I would propose to move the currentNode and possible other information about the current rendering into a singleton (NodeRenderingEnvironment tbd.) to prevent it being lost.
The change: https://review.typo3.org/#/c/10173 is a quick fix for the Quebec site to circumvent the problem but shouldn't be merged (or just as a temporary solution)
Associated revisions
[BUGFIX] Change Context behavior to avoid mixed context
With this change the context is derived from the node repository
instead from each node, to avoid mixing up contexts during
the rendering process.
Fixes: #35736
Change-Id: Ib4336e57b3eef3198373485cdbee652552f130a1
[BUGFIX] Change Context behavior to avoid mixed context
With this change the context is derived from the node repository
instead from each node, to avoid mixing up contexts during
the rendering process.
Resolves: #35736
Change-Id: Ib4336e57b3eef3198373485cdbee652552f130a1
History
#1 Updated by Christian Müller over 3 years ago
- Status changed from New to Accepted
- Assigned To set to Christian Müller
- Priority changed from Should have to Must have
#2 Updated by Gerrit Code Review over 3 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10173
#3 Updated by Gerrit Code Review over 3 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10260
#4 Updated by Gerrit Code Review over 3 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10173
#5 Updated by Gerrit Code Review over 3 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10173
#6 Updated by Gerrit Code Review over 3 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10173
#7 Updated by Christian Müller over 3 years ago
- Status changed from Accepted to Under Review
#8 Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10260
#9 Updated by Gerrit Code Review over 3 years ago
Patch set 8 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10173
#10 Updated by Gerrit Code Review over 3 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10260
#11 Updated by Gerrit Code Review over 3 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10260
#12 Updated by Gerrit Code Review over 3 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10260
#13 Updated by Gerrit Code Review over 3 years ago
Patch set 9 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10173
#14 Updated by Gerrit Code Review over 3 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10260
#15 Updated by Gerrit Code Review over 3 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10260
#16 Updated by Gerrit Code Review over 3 years ago
Patch set 8 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10260
#17 Updated by Gerrit Code Review over 3 years ago
Patch set 10 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10173
#18 Updated by Gerrit Code Review over 3 years ago
Patch set 9 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10260
#19 Updated by Gerrit Code Review over 3 years ago
Patch set 11 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10173
#20 Updated by Gerrit Code Review over 3 years ago
Patch set 10 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10260
#21 Updated by Gerrit Code Review over 3 years ago
Patch set 11 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10260
#22 Updated by Gerrit Code Review over 3 years ago
Patch set 12 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10260
#23 Updated by Gerrit Code Review over 3 years ago
Patch set 13 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10260
#24 Updated by Gerrit Code Review over 3 years ago
Patch set 12 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10173
#25 Updated by Christian Müller over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset commit:c1d84cfbe979225da742299343787ebde507a0f9.
#26 Updated by Robert Lemke almost 3 years ago
- Project changed from Base Distribution to TYPO3.Neos