Bug #36030

Forwarding of CLI requests throws an exception

Added by Alexander Stehlik over 3 years ago. Updated over 3 years ago.

Status:Resolved Start date:2012-04-14
Priority:Should have Due date:
Assigned To:- % Done:

100%

Category:Command
Target version:-
PHP Version: Complexity:easy
Has patch:No Affected Flow version:Git master

Description

When you call a CLI action with missing parameters you get an exception with no further explanation.

This is because TYPO3\FLOW3\Cli\CommandController::forward() throws a\TYPO3\FLOW3\MVC\Exception\StopActionException that is not catched anywhere.

Expected behaviour would be to catch the exception and try do process a new request.


Related issues

related to TYPO3.Flow - Bug #32665: CLI Requests must still work even if firewall rejectAll i... Closed 2011-12-18

Associated revisions

Revision f9847d2b
Added by Alexander Stehlik over 3 years ago

[BUGFIX] Fixed empty exception for CLI commands

When issuing an invalid command line (missing or wrong arguments),
FLOW3 displayed an exception #0 without further explanation.
The reason was an uncaught StopActionException thrown in the
CommandController::forward() method.

This patch fixes that bug and additionally eliminates some
duplicate code in CommandRequestHandler.

Fixes: #36030
Releases: 1.1
Change-Id: Ie4b42b63010890befd94f1df2f199c03d6b82197

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10456

#2 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10456

#3 Updated by Alexander Stehlik over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF