Bug #36031

T3D export of tt_content elements with IRRE relations between each other fails

Added by Jo Hasenau over 3 years ago. Updated about 2 years ago.

Status:Resolved Start date:2012-04-14
Priority:Must have Due date:
Assigned To:- % Done:

100%

Category:Backend API Spent time: -
Target version:4.5.15
TYPO3 Version:4.5 Is Regression:
PHP Version:5.3 Sprint Focus:
Complexity:

Description

When exporting a structure containing grid elements to a T3D, there will be lots of warnings about elements being "recursive".
A reimport will on the hand give all elements back, but the relations will be completely broken.

Relations between elements are constructed using proper TCA settings of the type "inline".
Even the rest of the setup for the fields is done with plain core funcitonality.

So it seems there is a problem while exporting tt_content elements that are related to each other.

The result after importing it, gives the impression, that it might be a double export attempt on any child element, so that they will be exported as single elements once, and in a second attempt there is a try to export them again as a child element of a parent grid.
The last one fails leaving us with child elements moved from their container element to the page.

Tested with 4.6.x, but I guess the problem will be the same with 4.5.x


Related issues

related to Core - Task #49162: Rewrite install tool Resolved 2011-10-30
related to Grid Elements - Bug #36026: Exporting and reimporting a page tree with grid elements ... Resolved 2012-04-14
duplicated by Grid Elements - Bug #46539: When using T3D export import the nested CE elements are n... Rejected 2013-03-22

Associated revisions

Revision c4abdecd
Added by Stefan Galinski about 2 years ago

[TASK] Provide information about import action in TCEmain to hooks

While importing T3D files the TCEmain currently fires the required
processing on records just as if the editor is generating the records. If
extensions hook into TCEmain, there is no way to differenciate this
situation from the regular editing mode - which might provide unexpected
results, i.e. wrong IRRE relations.

Solution is to provide a boolean to indicate that TCEmain has been called
during an import action which extensions could use to recognize this
situation.

Change-Id: I4fe429fb88f8ec24a7fda885f38ddfbdb4a642f5
Resolves: #36031
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/10515
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Revision 42e4d7c8
Added by Stefan Galinski about 2 years ago

[TASK] Provide information about import action in TCEmain to hooks

While importing T3D files the TCEmain currently fires the required
processing on records just as if the editor is generating the records. If
extensions hook into TCEmain, there is no way to differenciate this
situation from the regular editing mode - which might provide unexpected
results, i.e. wrong IRRE relations.

Solution is to provide a boolean to indicate that TCEmain has been called
during an import action which extensions could use to recognize this
situation.

Change-Id: I4fe429fb88f8ec24a7fda885f38ddfbdb4a642f5
Resolves: #36031
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/22642
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Revision 2feccc54
Added by Stefan Galinski about 2 years ago

[TASK] Provide information about import action in TCEmain to hooks

While importing T3D files the TCEmain currently fires the required
processing on records just as if the editor is generating the records. If
extensions hook into TCEmain, there is no way to differenciate this
situation from the regular editing mode - which might provide unexpected
results, i.e. wrong IRRE relations.

Solution is to provide a boolean to indicate that TCEmain has been called
during an import action which extensions could use to recognize this
situation.

Change-Id: I4fe429fb88f8ec24a7fda885f38ddfbdb4a642f5
Resolves: #36031
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/22643
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Revision 632ea145
Added by Stefan Galinski about 2 years ago

[TASK] Provide information about import action in TCEmain to hooks

While importing T3D files the TCEmain currently fires the required
processing on records just as if the editor is generating the records. If
extensions hook into TCEmain, there is no way to differenciate this
situation from the regular editing mode - which might provide unexpected
results, i.e. wrong IRRE relations.

Solution is to provide a boolean to indicate that TCEmain has been called
during an import action which extensions could use to recognize this
situation.

Change-Id: I4fe429fb88f8ec24a7fda885f38ddfbdb4a642f5
Resolves: #36031
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/22645
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Revision 38a59eaf
Added by Stefan Galinski about 2 years ago

[TASK] Provide information about import action in TCEmain to hooks

While importing T3D files the TCEmain currently fires the required
processing on records just as if the editor is generating the records. If
extensions hook into TCEmain, there is no way to differenciate this
situation from the regular editing mode - which might provide unexpected
results, i.e. wrong IRRE relations.

Solution is to provide a boolean to indicate that TCEmain has been called
during an import action which extensions could use to recognize this
situation.

Change-Id: I4fe429fb88f8ec24a7fda885f38ddfbdb4a642f5
Resolves: #36031
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/22644
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/10495

#2 Updated by Jo Hasenau over 3 years ago

The problem with the double elements is a reulst of a process_datamap hook action of grid elements itself.

But this is just due to the fact that process_datamap is used while importin as well, but without any additional information about TCE main being called by the import action.

So the hook methods will apply stuff that should be applied while copying, moving or creating elements during the usual editing process only.

The solution is to provide a boolean switch, that can be set during the import so that the hooks will "know" about the "isImporting" state.

#3 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10511

#4 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/10513

#5 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10515

#6 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10515

#7 Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10515

#8 Updated by Gerrit Code Review about 3 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10515

#9 Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10515

#10 Updated by Gerrit Code Review about 2 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/10515

#11 Updated by Gerrit Code Review about 2 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/10515

#12 Updated by Gerrit Code Review about 2 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/10515

#13 Updated by Stefan Galinski about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF