Bug #36184

Feature #31893: Allow XCLASSes to be defined via ext_autoload.php

Remove XCLASS blocks from t3lib

Added by Tolleiv Nietsch over 3 years ago. Updated over 3 years ago.

Status:Resolved Start date:2012-04-16
Priority:Should have Due date:
Assigned To:Tolleiv Nietsch % Done:

100%

Category:- Spent time: -
Target version:6.0.0
TYPO3 Version:6.0 Is Regression:
PHP Version: Sprint Focus:
Complexity:

Description

After #31893 the XCLASS blocks from within the Core can be remove. This issue covers all t3lib related "actions".

During the removal the classes t3lib_timeTrack and t3lib_TimeTrackNull should be declared to be "final" as they're not supposed to be extended anyways (see inline docs).

Patch should not be merged before #36183 is done and merged - otherwise dbal will be broken on master.

Associated revisions

Revision 6be80a5d
Added by Tolleiv Nietsch over 3 years ago

[BUGFIX] Remove XCLASS inclusion blocks from t3lib

After #31893 is merged we can remove the XCLASS blocks from the
Core. This patchset removes it from the classes within t3lib.

Besides that it declares t3lib_TimeTrackNull and t3lib_TimeTrack
to be final to make sure that extending them is still denied.

This patchset itself should not be merged before the related patch
for EXT:dbal (#31183) is merged.

Change-Id: I09e5253191972ac4b3b033aeb770758690ea3755
Fixes: #36184
Releases: 6.0
Reviewed-on: http://review.typo3.org/10556
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision c7692cc3
Added by Tolleiv Nietsch about 3 years ago

[BUGFIX] Remove XCLASS inclusion blocks from t3lib

After #31893 is merged we can remove the XCLASS blocks from the
Core. This patchset removes it from the classes within t3lib.

Besides that it declares t3lib_TimeTrackNull and t3lib_TimeTrack
to be final to make sure that extending them is still denied.

This patchset itself should not be merged before the related patch
for EXT:dbal (#31183) is merged.

Change-Id: I09e5253191972ac4b3b033aeb770758690ea3755
Fixes: #36184
Releases: 6.0
Reviewed-on: http://review.typo3.org/10556
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10556

#2 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10556

#3 Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10556

#4 Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10556

#5 Updated by Tolleiv Nietsch over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF