Feature #36333: Using Locale parser in Float TypeConverter - TYPO3.Flow - TYPO3 Forge

TYPO3 Flow Base Distribution TYPO3.Eel TYPO3.Flow TYPO3.Fluid TYPO3.Kickstart TYPO3.Welcome Packages Applications

Feature #36333

Using Locale parser in Float TypeConverter

Added by Adrian Föder over 3 years ago. Updated about 3 years ago.

Status:

Resolved

Start date:

2012-04-19

Priority:

Should have

Due date:

Assigned To:

Adrian Föder

% Done:

100%

Category:

Property

Target version:

TYPO3 Flow Base Distribution - 2.0 beta 1

PHP Version:

Complexity:

Has patch:

Yes

Description

since the Validator has it, it would be nice and useful to let the Property Mapper use the Locale parser to differentiate between various given decimal and thousands separators

0001-FEATURE-FloatConverter-uses-Locale-parser.patch - Fix error on missing configuration and add unit tests (9.8 kB) Alexander Berl, 2012-04-28 22:10

Related issues

Associated revisions

Revision d10d076b
Added by Adrian Föder about 3 years ago

[FEATURE] FloatConverter uses Locale parser

If configured using the Property Mapping Configuration,
the FloatConverter now can also use the Locale parser
to get the intended `float` value from a string input.

Change-Id: Ib95c52d958d765eb0a9cd20e415642186e25ee57
Resolves: #36333
Releases: 1.2

Revision b83b9b43
Added by Karsten Dambekalns about 3 years ago

[BUGFIX] Fix functional tests after FloatConverter change

Somehow two failing functional tests went unnoticed so far,
broken with Ib95c52d958d765eb0a9cd20e415642186e25ee57.

Change-Id: Iafdcfeff0361579ae28910509e9301eba8c69a23
Related: #36333
Releases: 1.2

History

#1 Updated by Gerrit Code Review over 3 years ago

Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10634

#2 Updated by Alexander Berl over 3 years ago

I'd suggest using $this->localizationService->getConfiguration()->getCurrentLocale() instead of $this->localizationService->getConfiguration()->getDefaultLocale(), because it falls back to default locale but allows for overriding the locale via code (for example by parsing Accept-Language headers, or from session).

Other than that +1

#3 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10634

#4 Updated by Adrian Föder over 3 years ago

Has patch changed from No to Yes

thanks Alexander for the catch, could you review it again please and comment/vote directly on Gerrit? Thanks a lot!

#5 Updated by Alexander Berl over 3 years ago

File 0001-FEATURE-FloatConverter-uses-Locale-parser.patch added

I'm not sure how to push a change to this changeset and found no one on the IRC channel to give me some hints, so I'm just adding a patch diff.

This fixes the failing test when no configuration is given with the convertFrom call, adds conversion from float => float which resolves #35173 and adds some more unit tests for the new functionality.