Task #36340
Environment class needs to be cleaned up
| Status: | Resolved | Start date: | 2012-04-19 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | Environment | |||
| Target version: | TYPO3 Flow Base Distribution - 1.1 | |||
| Sprint: | Has patch: | No | ||
| PHP Version: | Complexity: |
Description
With the HTTP foundation quite some things from Environment have become obsolete. The class and it's "users" need to be adjusted.
Related issues
Associated revisions
[!!!][TASK] Clean up Environment after HTTP refactoring
With the HTTP foundation quite some things from Environment have become
obsolete. The class and it's "users" are adjusted in this change.
The following methods are removed from Environment (check Http\Request
to see if a method you need is available there) with this change:
- setBaseUri
- getHTTP*
- getAcceptedFormats
- getRemoteAddress
- getRemoteHost
- getRequestProtocol
- getRequestUri
- getBaseUri
- getScriptPathAndFileName
- getScriptRequestPathAndFileName
- getScriptRequestPath
- getRequestMethod
- getCommandLineArgumentCount
- getCommandLineArguments
- getSAPIName
- getRawGetArguments
- getRawPostArguments
- getUploadedFiles
- getRawServerEnvironment
Most of those were marked as public API, but we still decided to drop
them, as their use cases were only guesswork.
For some things that used to be available, access to the current request
is now needed. For this, getHttpRequest() was added to the new
HttpRequestHandlerInterface, which returns the current HttpRequest.
Change-Id: I18fe7d44207bd2e170eec72d60d7d92ed91cf152
Resolves: #36340
Related: #35243
Releases: 1.1
History
#1 Updated by Gerrit Code Review over 3 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10662
#2 Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10662
#3 Updated by Gerrit Code Review over 3 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10662
#4 Updated by Gerrit Code Review over 3 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10662
#5 Updated by Gerrit Code Review over 3 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10662
#6 Updated by Gerrit Code Review over 3 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10662
#7 Updated by Gerrit Code Review over 3 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10662
#8 Updated by Karsten Dambekalns over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 817017e0051be25da3a675c666f811f88a62c802.