Bug #36518
Http\Request::createFromEnvironment does not work on CLI
| Status: | Resolved | Start date: | 2012-04-24 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Christopher Hlubek | % Done: | 100% |
|
| Category: | Http | |||
| Target version: | TYPO3 Flow Base Distribution - 1.1 | |||
| PHP Version: | Complexity: | |||
| Has patch: | Yes | Affected Flow version: | Git master |
Description
Calling Http\Request::createFromEnvironment gives a notice about an undefined array index for HTTP_HOST and REMOTE_URI. This should be guarded in the Request implementation.
Associated revisions
[BUGFIX] Guard against missing server global variables
Calling Http\Request::createFromEnvironment() gives a notice about an
undefined array index for HTTP_HOST and REMOTE_URI if used e.g. in
CLI based tests.
This change adds guards against this in the Request implementation.
Change-Id: Ib68c4de2777c651a9a9f1f5769e18eaa6efcfea2
Fixes: #36518
Releases: 1.1
History
#1 Updated by Gerrit Code Review over 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10742
#2 Updated by Christopher Hlubek over 3 years ago
- Has patch changed from No to Yes
#3 Updated by Karsten Dambekalns over 3 years ago
- Category set to Http
- Target version set to 1.1
#4 Updated by Gerrit Code Review over 3 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10742
#5 Updated by Gerrit Code Review over 3 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10742
#6 Updated by Christopher Hlubek over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100