Bug #36662

Checked state isn't always correct when property is collection

Added by Kevin Ulrich Moschallski over 3 years ago. Updated almost 2 years ago.

Status:Needs Feedback Start date:2012-04-27
Priority:Should have Due date:
Assigned To:Kevin Ulrich Moschallski % Done:

0%
Category:ViewHelpers
Target version:TYPO3 Flow Base Distribution - 1.1.1
Has patch:No Affected Flow version:Git 1.1

Description

The checkboxViewHelper doesn't always set the correct checked state when the property is an collection. I took the mechanism of the selectViewHelper and put it in the checkboxViewHelper.

Related issues

related to TYPO3.Fluid - Bug #33628: Multicheckboxes (multiselect) for Collections don’t work Needs Feedback 2012-02-02

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10829

#2 Updated by Karsten Dambekalns about 3 years ago

  • Assigned To set to Kevin Ulrich Moschallski
  • Target version set to 1.1 RC1
  • Affected Flow version changed from Git master to Git 1.1

#3 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10829

#4 Updated by Karsten Dambekalns about 3 years ago

  • Target version changed from 1.1 RC1 to 1.1

#5 Updated by Gerrit Code Review about 3 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10829

#6 Updated by Gerrit Code Review about 3 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10829

#7 Updated by Gerrit Code Review about 3 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10829

#8 Updated by Bastian Waidelich about 3 years ago

  • Status changed from Under Review to Needs Feedback

@Kevin could you please give some feedback on how to reproduce the problem

1<ul>
2    <f:for each="{someCollection}" as="someItem">
3        <li>
4            <f:form.checkbox property="someCollection" multiple="true" value="{someItem}" /> {someItem.title}
5        </li>
6    </f:for>
7</ul>

Works for me.

#9 Updated by Kevin Ulrich Moschallski about 3 years ago

Hi Bastian,

my case looks like yours and with the patch applied it works fine for me. If you want i could upload my test package somewhere.

#10 Updated by Bastian Waidelich about 3 years ago

Kevin Ulrich Moschallski wrote:

Hi Kevin,

my case looks like yours and with the patch applied it works fine for me.
If you want i could upload my test package somewhere.

Thanks for the feedback, but what I was trying to say is "Works for me without the patch"

#11 Updated by Karsten Dambekalns almost 3 years ago

  • Target version changed from 1.1 to 1.1.1

#12 Updated by Karsten Dambekalns over 2 years ago

  • Target version changed from 1.1.1 to 2052

#13 Updated by Karsten Dambekalns almost 2 years ago

  • Target version changed from 2052 to 1.1.1

Also available in: Atom PDF