Bug #36988

PropertyMapper chokes on Objects that are already converted

Added by Marc Neuhaus about 3 years ago. Updated over 2 years ago.

Status:Resolved Start date:2012-12-25
Priority:Must have Due date:
Assigned To:Sebastian Kurfuerst % Done:

100%
Category:Property
Target version:TYPO3 Flow Base Distribution - 1.1 beta 3
PHP Version: Complexity:
Has patch:No Affected Flow version:Git master

Description

I've noticed that the PropertyMapper chokes on Objects which are already in the Target form.
This happened to me with the TYPO3.Form Project in case where the DatePickerViewHelper already transforms the Value to a DateTime and the FormHandler later tries to map it again which fails because he isn't supposed to handle objects.

In this case i would suggest, to check if the source property is of the target property and skip it in that case.

Here's the origination ticket:
http://forge.typo3.org/issues/36722#note-8

PropertyMapper.diff Magnifier (518 Bytes) Marc Neuhaus, 2012-05-13 14:38

Subtasks

Bug #40661: The PropertyMapper can still choke on compositeTypes like...ResolvedMarc Neuhaus

Related issues

related to TYPO3.Form - Feature #36722: Support identifiers with special characters Resolved 2012-04-30
related to TYPO3.Flow - Bug #39445: PropertyMapper chokes on Objects that are already convert... Resolved 2012-12-25
blocks Foo.ContentManagement - Major Feature #37293: Refactor Admin to work inside Phoenix as Foo.ContentManag... New 2012-05-18

Associated revisions

Revision 6695a4cb
Added by Sebastian Kurfuerst about 3 years ago

[BUGFIX] Property Mapper chokes on already-converted objects

This happens for example when using the TYPO3.Form Project with a DatePicker,
which already transforms the value to the correct data type.

Change-Id: I884d4a82d41f4c5687536e46b56def8d1d86f9e8
Fixes: #36988
Releases: 1.1, 1.2

Revision c2caff24
Added by Sebastian Kurfuerst about 3 years ago

[BUGFIX] Property Mapper chokes on already-converted objects

This happens for example when using the TYPO3.Form Project with a DatePicker,
which already transforms the value to the correct data type.

Change-Id: I884d4a82d41f4c5687536e46b56def8d1d86f9e8
Fixes: #36988
Releases: 1.1, 1.2

History

#1 Updated by Marc Neuhaus about 3 years ago

Here's a little Patch to check if the source is an object and return it if it's an instance of the target type.

#2 Updated by Bastian Waidelich about 3 years ago

  • Subject changed from PropertyMapper chokes on Objects which are already in the target form to PropertyMapper chokes on Objects that are already converted
  • Category set to Property
  • Target version set to 1.1 beta 1

#3 Updated by Karsten Dambekalns about 3 years ago

  • Target version changed from 1.1 beta 1 to 1.1

#4 Updated by Karsten Dambekalns about 3 years ago

  • Target version changed from 1.1 to 1.1 RC1

#5 Updated by Sebastian Kurfuerst about 3 years ago

  • Status changed from New to Accepted
  • Priority changed from Should have to Must have

#6 Updated by Gerrit Code Review about 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11724

#7 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11724

#8 Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12168

#9 Updated by Sebastian Kurfuerst about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Karsten Dambekalns about 3 years ago

  • Target version changed from 1.1 RC1 to 1.1 beta 3

Also available in: Atom PDF