TYPO3.Flow

If I understand it correctly, the hash for a Value Object is calculated/done in Persistence\Aspect\PersistenceMagicAspect::generateValueHash().
It seems (I'm just "thinking loudly"), that that hash is built from

* the object's Persistence Identifier, if one
* the concatenated representation of each constructor method argument, processed as following:
  * a serialize(), if an array
  * its actual value, if not an object
  * its Persistence Identifier, if one
  * its timestamp, if DateTime

In my use case, a Doctrine Collection should also be part of the hash. I could imagine that this is not a seldom case in general, so I have two improvement suggestions:

• directly support the Doctrine collection case with a sub loop, for example, or the Collection->toArray() method
• or call a magic function, for example

 1/**
 2 * @FLOW3\ValueObject
 3 */
 4class FooBar {
 5    public function __construct() {
 6            // this is the constructor of this Value Object
 7        $this->that = 'some';
 8    }
 9
10    /**
11     * Generates the value object hash. Arguments are as in constructor.
12     * @param mixed $argument1 
13     * @param mixed $argument2 
14     * @return string The value object hash
15     */
16    public static function generateValueObjectHash() {
17        foreach (func_get_args()) ... whatever...
18
19    }

This public static method could be, if present, called by the Aspect; else the usual process is applied to retrieve the hash.

What do you think? Should a customizable VO hash be possible altogether?