Bug #37352

generateValueHash() should use getIdentifierByObject()

Added by Karsten Dambekalns about 3 years ago. Updated about 2 years ago.

Status:Under Review Start date:2012-05-21
Priority:Must have Due date:
Assigned To:Karsten Dambekalns % Done:

0%

Category:Persistence
Target version:-
PHP Version: Complexity:
Has patch:No Affected Flow version:Git 1.0

Description

The generateValueHash() method only tries to use FLOW3_Persistence_Identifier directly, but should use getIdentifierByObject() to support custom identifier properties.


Related issues

related to TYPO3.Flow - Feature #37286: Include object properties in Value Object hash creation Closed 2012-05-18

History

#1 Updated by Gerrit Code Review about 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/11598

#2 Updated by Karsten Dambekalns about 3 years ago

  • Target version changed from 1.1 beta 2 to 2.0 beta 1

Postponed because of possible side effects… Will need some more work.

#3 Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11722

#4 Updated by Karsten Dambekalns over 2 years ago

  • Target version changed from 2.0 beta 1 to 2.1

#5 Updated by Robert Lemke about 2 years ago

  • Target version deleted (2.1)

Also available in: Atom PDF