Bug #37403

IdentityRoutePart should set __identity array

Added by Bastian Waidelich about 3 years ago. Updated about 3 years ago.

Status:Resolved Start date:2012-05-22
Priority:Should have Due date:
Assigned To:Bastian Waidelich % Done:

100%

Category:MVC - Routing
Target version:TYPO3 Flow Base Distribution - 1.1 beta 2
PHP Version: Complexity:
Has patch:No Affected Flow version:FLOW3 1.0.0

Description

IdentityRoutePart::matchValue() currently returns the identifier of the ObjectPathMapping record directly.
This makes it difficult to merge arguments with data from the requestBody (e.g. for PUT requests).
Instead, the route part should return an array in the format array('__identity' => '<Identifier>')


Related issues

related to TYPO3.Flow - Feature #37402: Make request handling RESTfuller Resolved 2012-05-22
related to TYPO3.Flow - Bug #38404: IdentityRoutePart should accept __identity array Resolved 2012-06-26

Associated revisions

Revision 02fc35be
Added by Bastian Waidelich about 3 years ago

[TASK] IdentityRoutePart should return __identity array

IdentityRoutePart::matchValue() currently returns the identifier
of the ObjectPathMapping record directly.
This makes it difficult to merge arguments with data from the
requestBody (e.g. for PUT requests).

This change adjusts the route part so that it sets $this->value
to an array in the format array('__identity' => '<Identifier>')

Change-Id: I8b8cca1e20a2caf85ba51680ca79c4d74c16ed8b
Fixes: #37403
Related: #37402
Releases: 1.1, 1.2

Revision c7da751a
Added by Bastian Waidelich about 3 years ago

[TASK] IdentityRoutePart should return __identity array

IdentityRoutePart::matchValue() currently returns the identifier
of the ObjectPathMapping record directly.
This makes it difficult to merge arguments with data from the
requestBody (e.g. for PUT requests).

This change adjusts the route part so that it sets $this->value
to an array in the format array('__identity' => '<Identifier>')

Change-Id: I8b8cca1e20a2caf85ba51680ca79c4d74c16ed8b
Fixes: #37403
Related: #37402
Releases: 1.1, 1.2

History

#1 Updated by Gerrit Code Review about 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11503

#2 Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/11747

#3 Updated by Bastian Waidelich about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF