Bug #37958

Authentication no longer triggered for inaccessible node

Added by Karsten Dambekalns about 3 years ago. Updated about 3 years ago.

Status:Resolved Start date:2012-06-12
Priority:Should have Due date:
Assigned To:Christian Müller % Done:

100%
Category:Node handling
Target version:Base Distribution - Sprint 9

Description

Until now we could redirect to the "My T3CON" page from the typo3.org SSO login and the user would be authenticated. This does not work any longer since this change:

e6aac075332b526e7fde5e22ebd370238d43c99d
commit e6aac075332b526e7fde5e22ebd370238d43c99d
Author: Christian Müller <christian@kitsunet.de>
Date:   Tue May 22 18:03:52 2012 +0200

    [BUGFIX] Nodes with access roles should behave as expected

    Change-Id: Ib21f641ed15164b15a5d48397511234ad503d59c

diff --git a/Classes/Domain/Model/Node.php b/Classes/Domain/Model/Node.php
index 3147220..a445eda 100644
--- a/Classes/Domain/Model/Node.php
+++ b/Classes/Domain/Model/Node.php
@@ -972,7 +972,7 @@ class Node implements NodeInterface {
                        return NULL;
                }

-               if (!$this->isAccessible() && !$this->nodeRepository->getContext()->isInaccessibleContentShown()) {
+               if (!$node->isAccessible() && !$this->nodeRepository->getContext()->isInaccessibleContentShown()) {
                        return NULL;
                }
                return $node;

Now instead of being authenticated a 404 is returned, as the node is not "found" in the first place.

History

#1 Updated by Christian Müller about 3 years ago

  • Status changed from New to Accepted
  • Assigned To set to Christian Müller

Probably needs adaptions in the RoutePartHandler, I will take care.

#2 Updated by Karsten Dambekalns about 3 years ago

  • Status changed from Accepted to Needs Feedback

That's solved, no?

#3 Updated by Karsten Dambekalns about 3 years ago

  • Status changed from Needs Feedback to Resolved
  • Target version set to Sprint 9
  • % Done changed from 0 to 100

Also available in: Atom PDF