Bug #37997

Recursion detection in instantiateClass is broken

Added by Karsten Dambekalns about 3 years ago. Updated about 3 years ago.

Status:Resolved Start date:2012-06-13
Priority:Should have Due date:
Assigned To:Karsten Dambekalns % Done:

100%

Category:Object
Target version:TYPO3 Flow Base Distribution - 1.1 beta 3
PHP Version: Complexity:
Has patch:No Affected Flow version:Git 1.0

Description

The recursion detection in instantiateClass of the ObjectManager is broken - if the speed-optimized path is used, the requested class is not removed from the list of classes being instantiated.

Associated revisions

Revision 88988c58
Added by Karsten Dambekalns about 3 years ago

[BUGFIX] Fix recursion detection in instantiateClass

When in ObjectManager->instantiateClass() the speedup case was
used, recursion detection would potentially fail, as it returns
early without removing the class name from the list of classes
currently being instantiated.

Change-Id: Ibbe013952c92a10f209eedf87299a16377aa691e
Fixes: #37997
Releases: 1.1, 1.2

Revision b898eb9b
Added by Karsten Dambekalns about 3 years ago

[BUGFIX] Fix recursion detection in instantiateClass

When in ObjectManager->instantiateClass() the speedup case was
used, recursion detection would potentially fail, as it returns
early without removing the class name from the list of classes
currently being instantiated.

Change-Id: Ibbe013952c92a10f209eedf87299a16377aa691e
Fixes: #37997
Releases: 1.1, 1.2

History

#1 Updated by Gerrit Code Review about 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12023

#2 Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12186

#3 Updated by Karsten Dambekalns about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Karsten Dambekalns about 3 years ago

  • Target version changed from 1.1 RC1 to 1.1 beta 3

Also available in: Atom PDF