Bug #38244

't3lib_lock' does not exist if $TYPO3_CONF_VARS['SYS']['systemLog'] = 'file,...'

Added by Simon Apold about 3 years ago. Updated about 3 years ago.

Status:Rejected Start date:2012-06-21
Priority:Won't have this time Due date:
Assigned To:- % Done:

0%

Category:- Spent time: -
Target version:4.7.2
TYPO3 Version:4.7 Is Regression:
PHP Version:5.3 Sprint Focus:
Complexity:

Description

If the systemLog is configured to file ($TYPO3_CONF_VARS['SYS']['systemLog'] = 'file,...'), the workspace-module won't work.
It will only show an error message: "router - class 't3lib_lock' does not exist".

Patch1.diff Magnifier (609 Bytes) Simon Apold, 2012-06-21 09:42


Related issues

related to Core - Bug #34662: Fatal error 't3lib_lock' does not exist if deprecationLog... Resolved 2012-03-08
related to Core - Bug #36241: Call-time pass-by-reference has been deprecated Resolved 2012-04-17

History

#1 Updated by Simon Apold about 3 years ago

I attached a patch, which fixes this issue.

#2 Updated by Philipp Gampe about 3 years ago

Hi, do you mind pushing the patch to gerrit?

http://wiki.typo3.org/Contribution_Walkthrough_Tutorials

One nitpick for the patch, the comment needs one more tab of indention (always one more than the code).

#3 Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12260

#4 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12260

#5 Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12264

#6 Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12269

#7 Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/12275

#8 Updated by Christian Kuhn about 3 years ago

Is this still reproducible after #36241 is merged in 4.7?

To test please checkout workspaces_4-7 current branch in typo3/sysext/workspaces.

#9 Updated by Simon Apold about 3 years ago

Your right, with the patch in #36241 this issue is not reproducible any more.
It seems, that any other PHP error message or even notice will cause this behaviour.
Should i abandon this change?

#10 Updated by Wouter Wolters about 3 years ago

Can be abandoned:)

#11 Updated by Ernesto Baschny about 3 years ago

  • Status changed from Under Review to Rejected
  • Priority changed from Must have to Won't have this time

Also available in: Atom PDF