Bug #38736

Task #38755: Usability issues collected on the UX sprint

Cleanup TCEform FlexForm section HTML and JS code

Added by Benjamin Mack about 3 years ago. Updated 9 months ago.

Status:Resolved Start date:2012-07-07
Priority:Should have Due date:
Assigned To:Benjamin Mack % Done:

100%
Category:Backend User Interface Spent time: -
Target version:-
TYPO3 Version:6.0 Is Regression:
PHP Version: Sprint Focus:
Complexity:

Description

The existing JS code for TCEform FlexForm sections is messy, mostly inline and not easy to maintain, the first part of the cleanup streamlines the HTML and the JavaScript.

  • Adds a jQuery version of the JavaScript features
    for TCEform FlexForms, and include them in
    the TYPO3 rendering call when accessing
    TCEforms FlexForms.
  • Adds clean "t3-flex" prefixed CSS classes for all
    components of FlexForms sections. Added styling
    for the components with the new classes
  • Removes all existing inline JS code for FlexForms
  • Adds minor bug fixes (no title output for section
    elements, preview text will be rendered on load on
    hidden section elements)
  • Reviewed existing ACTION code in TCEmain
    for flexform elements

Associated revisions

Revision 1460e9ec
Added by Benjamin Mack 9 months ago

[CLEANUP] Rewrite JS/HTML part of Flexform sections

  • Adds a jQuery version of the JavaScript features
    for TCEform FlexForms, and include them in
    the TYPO3 rendering call when accessing
    TCEforms FlexForms. * Adds clean "t3-flex" prefixed CSS classes for all
    components of FlexForms sections. Added styling
    for the components with the new classes * Removes all existing inline JS code for FlexForms * Adds minor bug fixes (no title output for section
    elements, preview text will be rendered on load on
    hidden section elements) * Reviewed existing ACTION code in TCEmain
    for flexform elements

One minor side note is that sorting is not working, which
will immediately be replaced with jquery ui in a followup
patch.

Resolves: #38736
Releases: master
Change-Id: I9fadf06d3271dd771489fcdd182cddf9542b59fd
Reviewed-on: http://review.typo3.org/12698
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12698

#2 Updated by Steffen Ritter about 3 years ago

  • Category set to Backend User Interface
  • Assigned To set to Benjamin Mack
  • Parent task set to #38755

#3 Updated by Gerrit Code Review 11 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/12698

#4 Updated by Gerrit Code Review 11 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/12698

#5 Updated by Gerrit Code Review 9 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/12698

#6 Updated by Gerrit Code Review 9 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/12698

#7 Updated by Gerrit Code Review 9 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/12698

#8 Updated by Gerrit Code Review 9 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/12698

#9 Updated by Gerrit Code Review 9 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/12698

#10 Updated by Benjamin Mack 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF