Bug #38841

Magic findBy methods in Doctrine\Repository do not return QueryResult

Added by Karsten Dambekalns about 3 years ago. Updated about 3 years ago.

Status:Resolved Start date:2012-07-10
Priority:Should have Due date:
Assigned To:Karsten Dambekalns % Done:

100%

Category:Persistence
Target version:TYPO3 Flow Base Distribution - 1.1 RC2
PHP Version: Complexity:
Has patch:No Affected Flow version:(any)

Related issues

related to TYPO3.Flow - Bug #35035: Doctrine repository findAll is inconsistent Resolved 2012-03-20

Associated revisions

Revision 934c2c42
Added by Karsten Dambekalns about 3 years ago

[!!!][BUGFIX] Fix return values of Doctrine\Repository magic methods

Overrides __call from EntityRepository to make the methods return
the expected QueryResultInterface. Also adds support for countBy().

This is marked as a breaking change because if you relied on the
specific return values before, you need to adjust your code.

Along the way the code inside __call() is simplified.

Change-Id: Iac08c917a07ceb679b09f254b1167401ced6c77c
Fixes: #38841
Releases: 1.1, 1.2

Revision 53049d6c
Added by Karsten Dambekalns about 3 years ago

[!!!][BUGFIX] Fix return values of Doctrine\Repository magic methods

Overrides __call from EntityRepository to make the methods return
the expected QueryResultInterface. Also adds support for countBy().

This is marked as a breaking change because if you relied on the
specific return values before, you need to adjust your code.

Along the way the code inside __call() is simplified.

Change-Id: Iac08c917a07ceb679b09f254b1167401ced6c77c
Fixes: #38841
Releases: 1.1, 1.2

History

#1 Updated by Gerrit Code Review about 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12739

#2 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12739

#3 Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12877

#4 Updated by Karsten Dambekalns about 3 years ago

  • Status changed from Under Review to Resolved
  • Target version changed from 1.1 to 1.1 RC2
  • % Done changed from 0 to 100

Also available in: Atom PDF