Bug #38873

Remove eval from StandaloneViewTest

Added by Christian Müller about 3 years ago. Updated about 3 years ago.

Status:Resolved Start date:2012-07-11
Priority:Should have Due date:
Assigned To:Christian Müller % Done:

100%

Category:-
Target version:-
Has patch:No Affected Flow version:Git 1.2 (master)

Description

StandaloneViewTest uses eval to create a class that inherits from StandaloneView to override some things. This doesn't work properly with proxy classes and is evil anyway!

Associated revisions

Revision ec1b9049
Added by Christian Müller about 3 years ago

[BUGFIX] Remove eval from StandaloneViewTest

Removes the use of eval from the StandaloneViewTest so that
now a Fixture class is used that extends the StandaloneView.

Change-Id: Id171056e247e1f83ac1360915489762c85cc458a
Fixes: #38873
Related: #31179
Releases: 1.1, 1.2

Revision 50370f1a
Added by Karsten Dambekalns about 3 years ago

[BUGFIX] Move functional test configuration to Testing

This moves the functional test configuration to the
Testing context, to avoid errors in other contexts.

Change-Id: Iaec644e50a241c6391cb9dcacaa14274910e1ae0
Related: #38873
Releases: 1.2

Revision 73c686b0
Added by Christian Müller about 3 years ago

[BUGFIX] Remove eval from StandaloneViewTest

Removes the use of eval from the StandaloneViewTest so that
now a Fixture class is used that extends the StandaloneView.

Change-Id: Id171056e247e1f83ac1360915489762c85cc458a
Fixes: #38873
Related: #31179
Releases: 1.1, 1.2

History

#1 Updated by Gerrit Code Review about 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12753

#2 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12753

#3 Updated by Gerrit Code Review about 3 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12753

#4 Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12760

#5 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12760

#6 Updated by Christian Müller about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF