Bug #39197

Pagetree Filtering can't handle records moved in draft - errors and blanks

Added by Bart Dubelaar about 3 years ago. Updated about 2 years ago.

Status:Resolved Start date:2012-07-23
Priority:Should have Due date:
Assigned To:- % Done:

100%

Category:Pagetree Spent time: -
Target version:-
TYPO3 Version:6.0 Is Regression:
PHP Version: Sprint Focus:
Complexity:

Description

After moving a record in a draft workspace, the record can no longer be found by filtering the pagetree.
If the filter applies to a subpage of the moved record, then an error is thrown and the pagetree is not shown. The latter case relates to issue #25372.

Holds for 4.5 up till 6.0


Related issues

related to Core - Bug #25372: PHP Catchable Fatal Error: t3lib_iconWorks::getSpriteIcon... Closed 2011-03-22
related to Core - Bug #36281: Page tree filtering does not take draft titles into account Closed 2012-04-18

Associated revisions

Revision 1cada0cb
Added by Bart Dubelaar about 2 years ago

[BUGFIX] Pagetree filtering crashes on draft moves

This bugfix fixes the following pagetree issues encountered in
a draft workspace:

1. Records moved in draft could not be found
2. Pagetree would crash if a moved page occurs in the rootline of
a filtered page.
3. Filtering only looked at live page title not the draft title

Change-Id: I49c0082d013303d39c0c259a42f9bb74346ba7c8
Fixes: #39197
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/13040
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski

Revision 3ec77742
Added by Bart Dubelaar about 2 years ago

[BUGFIX] Pagetree filtering crashes on draft moves

This bugfix fixes the following pagetree issues encountered in
a draft workspace:

1. Records moved in draft could not be found
2. Pagetree would crash if a moved page occurs in the rootline of
a filtered page.
3. Filtering only looked at live page title not the draft title

Change-Id: I49c0082d013303d39c0c259a42f9bb74346ba7c8
Fixes: #39197
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21959
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Revision 5a365178
Added by Bart Dubelaar about 2 years ago

[BUGFIX] Pagetree filtering crashes on draft moves

This bugfix fixes the following pagetree issues encountered in
a draft workspace:

1. Records moved in draft could not be found
2. Pagetree would crash if a moved page occurs in the rootline of
a filtered page.
3. Filtering only looked at live page title not the draft title

Change-Id: I49c0082d013303d39c0c259a42f9bb74346ba7c8
Fixes: #39197
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/22332
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

History

#1 Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13040

#2 Updated by Bart Dubelaar about 3 years ago

Steps to reproduce all three forms of misbehavior:

1. Create two pages A & B and add a subpage C to B.
2. In a draft workspace move B inside A.
3. Search for C in the pagetree filter -> error
4. Search for B in the pagetree filet -> no result
5. Rename A to X.
6. Search for X -> no result

#3 Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13040

#4 Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13040

#5 Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13040

#6 Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13040

#7 Updated by Alexander Opitz about 2 years ago

Hi Bart,

can you rebase your patch to latest master?

#8 Updated by Gerrit Code Review about 2 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13040

#9 Updated by Gerrit Code Review about 2 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13040

#10 Updated by Bart Dubelaar about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Gerrit Code Review about 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/21959

#12 Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/22332

#13 Updated by Bart Dubelaar about 2 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF