Bug #39346

localconf migration wizard breaks if escaped tick is used

Added by Susanne Moog about 3 years ago. Updated about 3 years ago.

Status:Resolved Start date:2012-07-28
Priority:Must have Due date:
Assigned To:- % Done:

100%

Category:- Spent time: -
Target version:6.0.0-pre-beta1
TYPO3 Version:6.0 Is Regression:
PHP Version:5.4 Sprint Focus:
Complexity:medium

Description

Example:
phpmyadmin localconf:

$TYPO3_CONF_VARS['EXT']['extConf']['phpmyadmin'] = 'a:4:{s:12:"hideOtherDBs";a:7:{s:3:"cat";s:5:"basic";s:6:"subcat";s:5:"x/10z";s:4:"type";s:7:"boolean";s:5:"label";s:147:"Only show TYPO3 database in pMA: If enabled, only the TYPO3 database is available, otherwise pMA will show all databases the SQL-user has access to";s:4:"name";s:12:"hideOtherDBs";s:5:"value";s:1:"1";s:13:"default_value";s:1:"1";}s:9:"uploadDir";a:7:{s:3:"cat";s:5:"basic";s:6:"subcat";s:3:"x/z";s:4:"type";s:6:"string";s:5:"label";s:182:"Path for database dumps: If starting with a slash it\'s assumed as an absolute path to the directory where the dumps should be saved, otherwise it\'s relative to the TYPO3 installation";s:4:"name";s:9:"uploadDir";s:5:"value";s:21:"uploads/tx_phpmyadmin";s:13:"default_value";s:21:"uploads/tx_phpmyadmin";}s:10:"allowedIps";a:7:{s:3:"cat";s:5:"basic";s:6:"subcat";s:3:"x/z";s:4:"type";s:6:"string";s:5:"label";s:71:"Allowed IPs: Comma separated list of IPs that may access this extension";s:4:"name";s:10:"allowedIps";s:5:"value";s:0:"";s:13:"default_value";s:0:"";}s:12:"useDevIpMask";a:7:{s:3:"cat";s:5:"basic";s:6:"subcat";s:3:"x/z";s:4:"type";s:7:"boolean";s:5:"label";s:80:"Use devIpMask: Use devIpMask from Install Tool (notice: overrules above setting)";s:4:"name";s:12:"useDevIpMask";s:5:"value";s:1:"0";s:13:"default_value";s:1:"0";}}'; // Modified or inserted by TYPO3 Extension Manager.

Word: it\'s
becomes: it's
therefore breaking PHP parsing.

All values must be quoted - or used literally.


Related issues

related to Core - Feature #38562: Refactor localconf.php handling Resolved 2012-07-02

Associated revisions

Revision cb9cfc89
Added by Christian Kuhn about 3 years ago

[BUGFIX] Broken quoting in arrayExport

Tick (') must be quoted to \'

Change-Id: I006173f0d5e1e17de1ff8801c71c6167fd96087d
Resolves: #39346
Releases: 6.0

Revision d391f709
Added by Christian Kuhn about 3 years ago

[BUGFIX] Broken quoting in arrayExport

Tick (') must be quoted to \'

Change-Id: I006173f0d5e1e17de1ff8801c71c6167fd96087d
Resolves: #39346
Releases: 6.0
Reviewed-on: http://review.typo3.org/13225
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Revision 96cd54ab
Added by Christian Kuhn almost 3 years ago

[BUGFIX] Broken quoting in arrayExport

Tick (') must be quoted to \'

Change-Id: I006173f0d5e1e17de1ff8801c71c6167fd96087d
Resolves: #39346
Releases: 6.0
Reviewed-on: http://review.typo3.org/13225
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Revision 1ca9e357
Added by Christian Kuhn almost 3 years ago

[BUGFIX] Broken quoting in arrayExport

Tick (') must be quoted to \'

Change-Id: I006173f0d5e1e17de1ff8801c71c6167fd96087d
Resolves: #39346
Releases: 6.0
Reviewed-on: http://review.typo3.org/13225
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

History

#1 Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13225

#2 Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13225

#3 Updated by Christian Kuhn about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF