Bug #39428

Layout and partial identifiers should be independent of current controller name

Added by Alexander Berl about 3 years ago. Updated 11 months ago.

Status:Resolved Start date:2012-07-31
Priority:Must have Due date:
Assigned To:Alexander Berl % Done:

100%
Category:Core
Target version:TYPO3 Flow Base Distribution - 1.1.1
Has patch:No Affected Flow version:FLOW3 1.1.0 rc 2

Description

Currently, all templates get an identifier made up of package/subpackage, controller, prefix and unique hash.
This leads to all layouts and partials being compiled and cached once for each controller they are used from, even though the contents is independant and hence just a duplicate.

I suggest adding the controller name as part of the prefix in getTemplateIdentifier() only and stripping it from createIdentifierForFile().

Associated revisions

Revision b474d245
Added by Alexander Berl 11 months ago

[BUGFIX] Resolve duplicate layout and partial compilations

Layouts and partials are independent of the current controller and hence should
not have the controller name in their identifier to prevent duplicate
compilations and cache instances of the same content.
This change removes the controller name from identifiers of layouts and
partials, but leaves the identifier of templates untouched.

Change-Id: I4f6e5b576d9e17e15a3e16cb581bfa4edc54637a
Fixes: #39428
Releases: master, 2.2

Revision 6224bcf3
Added by Alexander Berl 11 months ago

[BUGFIX] Resolve duplicate layout and partial compilations

Layouts and partials are independent of the current controller and hence should
not have the controller name in their identifier to prevent duplicate
compilations and cache instances of the same content.
This change removes the controller name from identifiers of layouts and
partials, but leaves the identifier of templates untouched.

Change-Id: I4f6e5b576d9e17e15a3e16cb581bfa4edc54637a
Fixes: #39428
Releases: master, 2.2

History

#1 Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13391

#2 Updated by Karsten Dambekalns almost 3 years ago

  • Category set to Core
  • Assigned To set to Alexander Berl
  • Target version set to 1.1

#3 Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13391

#4 Updated by Karsten Dambekalns almost 3 years ago

  • Target version changed from 1.1 to 1.1.1

#5 Updated by Karsten Dambekalns over 2 years ago

  • Target version changed from 1.1.1 to 2052

#6 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13391

#7 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13391

#8 Updated by Karsten Dambekalns almost 2 years ago

  • Target version changed from 2052 to 1.1.1

#9 Updated by Gerrit Code Review 11 months ago

Patch set 5 for branch master of project Packages/TYPO3.Fluid has been pushed to the review server.
It is available at http://review.typo3.org/13391

#10 Updated by Gerrit Code Review 11 months ago

Patch set 1 for branch 2.2 of project Packages/TYPO3.Fluid has been pushed to the review server.
It is available at http://review.typo3.org/32430

#11 Updated by Alexander Berl 11 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF