TYPO3.Flow

Gnah, could somebody with the required permissions please fix the formatting?

The difference is that with defaults, these will be set if the value is not set at all. Therefore, all requests where no package/subpackage is set in the request will go to MyPackage\Api, which is not what I desire. I want it the other way round - only the requests to this subpackage have to match this route, no other requests. For them, I have a different URL scheme.

Andreas Wolf wrote:

I want it the other way round - only the requests to this subpackage have to match this route, no other requests.

Not sure whether I got this now, let me rephrase:
In your example you want the route to match only if the request path is "api/v1/<someController>/<someAction>" AND some other request argument (e.g. POST) is array('@package' => 'MyPackage', 'subpackage' => 'Api') ?
Or how would you specify those in your example?

Bastian Waidelich wrote:

Andreas Wolf wrote:

I want it the other way round - only the requests to this subpackage have to match this route, no other requests.

Not sure whether I got this now, let me rephrase:
In your example you want the route to match only if the request path is "api/v1/<someController>/<someAction>" AND some other request argument (e.g. POST) is array('@package' => 'MyPackage', 'subpackage' => 'Api') ?

No, I want all requests to /api/v1/.* to go to the Api subpackage. But I only want links to this subpackage to have a URL /api/v1/... This does not work if I set defaults, as all view helpers etc. where the package and/or subpackage is not set will then have these defaults applied - leading to errors because the controller is not found in the API subpackage.

Andreas Wolf wrote:

In your example you want the route to match only if the request path is "api/v1/<someController>/<someAction>" AND some other
request argument (e.g. POST) is array('@package' => 'MyPackage', 'subpackage' => 'Api') ?

No, I want all requests to /api/v1/.* to go to the Api subpackage. But I only want links to this subpackage to have a URL /api/v1/...
This does not work if I set defaults, as all view helpers etc. where the package and/or subpackage is not set will then have these defaults
applied - leading to errors because the controller is not found in the API subpackage.

Thanks for your patience, now I'm with you!
I didn't get it at first, because the behavior you describe was meant to be the default.. That is: when creating an URI you have to set all values that are defined in the Routes default (except for @format which is a bit special)..

I don't know when this changed or if it was broken form the start, but right now you can omit default values that are not part of the uriPattern..
Changing Route::compareAndRemoveMatchingDefaultValues() from

 1protected function compareAndRemoveMatchingDefaultValues(array $defaults, array &$routeValues) {
 2    foreach ($defaults as $key => $defaultValue) {
 3        if (isset($routeValues[$key])) {
 4            if (is_array($defaultValue)) {
 5                if (!is_array($routeValues[$key])) {
 6                    return FALSE;
 7                }
 8                return $this->compareAndRemoveMatchingDefaultValues($defaultValue, $routeValues[$key]);
 9            } elseif (is_array($routeValues[$key])) {
10                return FALSE;
11            }
12            if (strtolower($routeValues[$key]) !== strtolower($defaultValue)) {
13                return FALSE;
14            }
15            unset($routeValues[$key]);
16        }
17    }
18    return TRUE;
19}

to

 1protected function compareAndRemoveMatchingDefaultValues(array $defaults, array &$routeValues) {
 2    foreach ($defaults as $key => $defaultValue) {
 3        if (!isset($routeValues[$key])) {
 4            if ($defaultValue === '' || ($key === '@format' && $defaultValue === 'html')) {
 5                continue;
 6            }
 7            return FALSE;
 8        }
 9        if (is_array($defaultValue)) {
10            if (!is_array($routeValues[$key])) {
11                return FALSE;
12            }
13            return $this->compareAndRemoveMatchingDefaultValues($defaultValue, $routeValues[$key]);
14        } elseif (is_array($routeValues[$key])) {
15            return FALSE;
16        }
17        if (strtolower($routeValues[$key]) !== strtolower($defaultValue)) {
18            return FALSE;
19        }
20        unset($routeValues[$key]);
21    }
22    return TRUE;
23}

fixes this for me, but it would be quite a breaking change probably..
could you please verify if that works for you?

BTW: To make debugging with fluid easier you can replace line 263 of AbstractViewHelper from throw $exception; to return $exception->getMessage(); – we'll fix this in fluid asap

BTW: With

./flow routing:list

you can see in what order the routes are processed. Try including your "MyPackageB" routes before the "MyPackageA" routes or refine the routes to make them more specific

In fact, it is almost resolved. I tried it with plain Flow master today (well, mostly, I still have some custom patches applied, but they don't matter for this issue).

All in all #43589 solved most of my problems. One still remains though:

When building a route for these values (taken from System_Development.log):

@action => index
@controller => user
@package => mypackage
@subpackage => admin
@format => html

with these routes (only the relevant ones)

 1-
 2  name: 'User admin controller'
 3  uriPattern: 'admin/user/{user}(/{@action})'
 4  defaults:
 5    '@package':    'MyPackage'
 6    '@subpackage': 'Admin'
 7    '@controller': 'User'
 8    '@action':     'index'
 9
10-
11  name: 'Admin action'
12  uriPattern: 'admin/{@controller}(/{@action})'
13  defaults:
14    '@package':    'MyPackage'
15    '@subpackage': 'Admin'
16    '@action':     'index'

none of the routes matches, but instead a Flow default route is used. When I remove the default routes, exception #1301610453 is thrown.

When invoking admin/user/ manually, it works perfectly - so somehow the router does not seem to match the values to the route, though it should (package and subpackage are fixed as defaults, the controller is given and the action is both given in the route values and in the route's defaults).

Bastian Waidelich wrote:

Thanks for your feedback.

Just for clarification:
We use the terms

• match for the mapping of a URI path to the route values (incoming)
• resolve for mapping route values to an URI (outgoing)

In your example the @package route value ("qrserver") is not equal to the routes default value "MyPackage".
Was that just a typo in the issue description?

I'm sorry, that was in fact a typo.

Also your route values specify a @format which is not defined in the routes.

The route values come from Flow internally. I thought that @format would be html by default nevertheless, so I did not really care about this. I added @format: 'html' to the defaults section of all routes now nonetheless, so let's see if it helps.