Task #39977: Allow oneliners for throw statements - PHP_CodeSniffer - TYPO3 Forge

BLE Project DEV3 Editorial Team Extension Coordination Team flow3.typo3.org Marketing Team Quality Assurance Team ci.typo3.org PHP_CodeSniffer metrics.typo3.org Sandbox Screencast Team Server Team TER Team TYPO3 Association typo3.org and community tools Translation Team

Task #39977

Allow oneliners for throw statements

Added by Rens Admiraal almost 3 years ago. Updated over 2 years ago.

Status:

Rejected

Start date:

2012-08-19

Priority:

Should have

Due date:

Assigned To:

Andy Grunwald

% Done:

Category:

ControlStructures

Target version:

0.0.6

Branch:

Tags:

typo3flow

Description

The FLOW3 CGL allows oneline if statements if a throw statement is used: http://flow3.typo3.org/documentation/codingguidelines/php.html#if-statements

For this the sniffing should be loosened a bit to allow the oneliners in those cases

History

#1 Updated by Stefano Kowalke almost 3 years ago

Category set to ControlStructures
Status changed from New to Needs Feedback

This topic should discussed first, because it is not part of TYPO3v4 CGL yet. It is not forbidden nor allowed like in FLOW3 CGL . Please open a report at http://forge.typo3.org/projects/typo3v4-doc_core_cgl/issues.

#2 Updated by Rens Admiraal almost 3 years ago

I don't see why this should be discussed first as I ask for adding the rules to the FLOW3 rulesset.

More important, we spoke about this rule in Copenhagen and we'll probably remove the exception from the cgl. This would mean this issue can be closed. I'll update this issue as soon as I'm sure we'll change the cgl.