Bug #40561: Custom TCEforms validator from saltedpasswords is broken since namespace switch - Core - TYPO3 Forge

Core Indexed Search Linkvalidator Release Cycles Team Resources Workspaces & Versioning TYPO3 CMS Usability Team Community Extensions Distributions Feature-Requests TYPO3 6.2 Projects (+)(Archived Projects)

Bug #40561

Task #40095: Move core to namespaces

Custom TCEforms validator from saltedpasswords is broken since namespace switch

Added by Steffen Ritter almost 3 years ago. Updated almost 3 years ago.

Status:

Resolved

Start date:

2012-09-03

Priority:

Should have

Due date:

Assigned To:

Steffen Ritter

% Done:

100%

Category:

Spent time:

Target version:

TYPO3 Version:

6.0

Is Regression:

PHP Version:

Sprint Focus:

Complexity:

Description

saltedpasswords registers an eval function. Eval functions are included with the registered name as function name in JS.
If the registered class is a namespaced class name the resulting name of the js function includes \\ which breaks tceforms.

Fix saltedpasswords registration to use classic classname.

Related issues

Associated revisions

Revision c9deca16
Added by Steffen Ritter almost 3 years ago

[BUGFIX] Editing *_users with saltedpasswords active fails

Since the namespace changes, the custom form-field-
evaluators for passwords shipped by saltedpasswords are
registered using the namespaced classes.

As the registered class name is used by tceForms to build
an internal JS function, the JS is broken due to the fact
that backslashes are not allowed in JS function names.

This patch reverts back to "classic" classnames as eval
identifier.

Change-Id: Ica52c01456be7a8ee2b7988cc9773586852621a6
Fixes: #40561
Releases: 6.0
Reviewed-on: http://review.typo3.org/14315
Reviewed-by: Mario Rimann
Tested-by: Mario Rimann
Tested-by: Marcel Burkhalter
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter