Task #40691

Story #40628: As any user, I need a Content Module based on semantic technologies (IKS)

Test / fix image handling

Added by Sebastian Kurfuerst almost 3 years ago. Updated almost 3 years ago.

Status:Closed Start date:
Priority:Should have Due date:
Assigned To:Sebastian Kurfuerst % Done:

100%

Category:- Spent time: -
Target version:Sprint 10 (1.0 TP1) Estimated time:0.00 hour

Associated revisions

Revision 27d00eac
Added by Sebastian Kurfuerst almost 3 years ago

[FEATURE] Refactor, fix and improve image handling

This change implements reworked, cleaned up and fixed image handling.

NOTE: If you add an image content element and directly want to modify it,
the "apply" button does not activate. This is a bug in adding of nodes,
as described in #40860. This will be fixed lateron. As a workaround,
you should reload the backend after adding a new image content element.

It contains the following detail-improvements:

  • Uploading images works correctly
  • Cropping images works
  • Setting width and height works as expected
  • saving works
  • loading existing images works
  • We now consistently use "w" and "h" for width and height, in
    sync with jCrop
  • updated jCrop
  • various detail bugfixes
  • code cleanup and restructuring
  • When selecting an already-existing image, a loading indicator
    is shown while image metadata is fetched.
  • The server side ContentController is cleaned up, containing only
    the methods which are still used.

Resolves: #40691
Change-Id: Id640f0ce45fc4145336c66fe18823299f866b46b

History

#1 Updated by Sebastian Kurfuerst almost 3 years ago

  • Assigned To set to Sebastian Kurfuerst

#2 Updated by Sebastian Kurfuerst almost 3 years ago

  • Assigned To deleted (Sebastian Kurfuerst)

#3 Updated by Sebastian Kurfuerst almost 3 years ago

  • Assigned To set to Sebastian Kurfuerst

#4 Updated by Sebastian Kurfuerst almost 3 years ago

  • Status changed from New to Accepted

#5 Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14541

#6 Updated by Sebastian Kurfuerst almost 3 years ago

  • Status changed from Accepted to Under Review

#7 Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14541

#8 Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14541

#9 Updated by Sebastian Kurfuerst almost 3 years ago

  • Status changed from Under Review to Resolved
  • Estimated time set to 0.00
  • Remaining (hours) set to 0.0

#10 Updated by Sebastian Kurfuerst almost 3 years ago

  • % Done changed from 0 to 100

#11 Updated by Markus Goldbeck almost 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF