Bug #40773
Fatal error due to changes in SpriteHandler in TYPO3 6.0
| Status: | Closed | Start date: | 2012-09-09 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | TYPO3 Core / Other Extensions | |||
| Target version: | 1.6.0 |
Description
In the current TYPO3 master, feeditadvanced (current trunk) exits with a PHP fatal error, since the interface of the t3lib_SpriteManager class (now named \TYPO3\CMS\Backend\Sprite\SpriteManager) has changed.
40773-patch1.diff
(652 Bytes)
40773-patch2.diff
(653 Bytes)
Related issues
Associated revisions
[TASK] Fatal error due to changes in SpriteHandler in TYPO3 6.0
Fix call to sprite manager.
Change-Id: I7992b3ded81b70308b1c1d680675050bd37b6cb9
Resolves: #40773
Reviewed-on: http://review.typo3.org/31955
Reviewed-by: Chris topher <chrissitopher@gmx.de>
Tested-by: Chris topher <chrissitopher@gmx.de>
History
#1 Updated by Martin Helmich almost 3 years ago
- File 40773-patch1.diff added
The attached patch should fix this problem.
#2 Updated by Lorenz Ulrich almost 3 years ago
This is a core issue; the namespaces introduction is not yet compatible to PHP < 5.3.7 when dealing with interfaces. It doesn't make sense to solve that in each extension.
#3 Updated by Martin Helmich almost 3 years ago
- File 40773-patch2.diff added
Hi Lorenz,
thanks for your feedback. in my opinion however, this is not just a namespace issue.
In TYPO3 < 6.0, the t3lib_SpriteManager constructor accepts one argument, while in TYPO3 6.0 it does not accept any arguments. Furthermore, in 6.0 the method loadCacheFile is not present anymore. Since both methods are called within the ajax service, this would result in a fatal error regardless of namespacing.
Btw, I noticed that my previous patch contained a syntax error (sorry for that, updated version attached).
Best regards,
Martin
#4 Updated by Gerrit Code Review about 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master of project TYPO3CMS/Extensions/feeditadvanced has been pushed to the review server.
It is available at http://review.typo3.org/31955
#5 Updated by Chris topher about 1 year ago
Thanks for the patch, Martin! Committed!
#6 Updated by Chris topher about 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 58fddd8f2c19f16b2472368851c6a259d9717b82.
#7 Updated by Chris topher about 1 year ago
- Target version set to 1.6.0
#8 Updated by Chris topher 12 months ago
- Status changed from Resolved to Closed