Task #40790
Story #40628: As any user, I need a Content Module based on semantic technologies (IKS)
hallo controls broken --> because images are not there anymore
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Mattias Nilsson | % Done: | 100% |
|
| Category: | - | Spent time: | - | |
| Target version: | Sprint 10 (1.0 TP1) | Estimated time: | 0.00 hour |
Description
The Hallo editor (see screenshot) uses icons based on Fontawesome (http://fortawesome.github.com/Font-Awesome/). However, these icon CSS classes collide with the glyphicons provided by Twitter Bootstrap 2.
As a result, the editing controls are not visible anymore (see screenshot). To reproduce, just select a text in editing mode and see the black boxes to appear ;-)
To fix, we either find a way to include fontawesome icons in a way that they do not collide with our twitter bootstrap icons, or we add the necessary CSS and use twitter bootstrap icons inside the hallo editor.
Associated revisions
[FEATURE] Customization of Hallo toolbar controls
- Lots of issues due to bloated dom
- Missing specific class for link & font-size button
- Submenus not styled
Resolves: #40790
Change-Id: I8a75a12da259e45084ac9f198c5dd7c16ddaa3d9
History
#1 Updated by Sebastian Kurfuerst almost 3 years ago
- File Skitch.jpg added
#2 Updated by Sebastian Kurfuerst almost 3 years ago
- Status changed from New to Accepted
- Assigned To set to Mattias Nilsson
#3 Updated by Sebastian Kurfuerst almost 3 years ago
Mattias is working on it this evening
#4 Updated by Gerrit Code Review almost 3 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14522
#5 Updated by Gerrit Code Review almost 3 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14522
#6 Updated by Gerrit Code Review almost 3 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14522
#7 Updated by Mattias Nilsson almost 3 years ago
- Status changed from Accepted to Under Review
#8 Updated by Gerrit Code Review almost 3 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14522
#9 Updated by Gerrit Code Review almost 3 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14522
#10 Updated by Gerrit Code Review almost 3 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14522
#11 Updated by Gerrit Code Review almost 3 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14522
#12 Updated by Anonymous almost 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset commit:f052ef3908382e340252ce149e3ece4e43f77d5d.
#13 Updated by Markus Goldbeck almost 3 years ago
- Status changed from Resolved to Closed
- Estimated time set to 0.00
- Remaining (hours) set to 0.0