Bug #40888
Add ViewNotFoundException
| Status: | Resolved | Start date: | 2012-09-13 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Bastian Waidelich | % Done: | 100% |
|
| Category: | MVC | |||
| Target version: | TYPO3 Flow Base Distribution - 2.0 beta 1 | |||
| PHP Version: | Complexity: | |||
| Has patch: | No | Affected Flow version: | Git 1.2 (master) |
Description
As noted in a comment on https://review.typo3.org/14439 we should not use NotFoundView ourselves anymore. Thus it seems we should add a ViewNotFoundException exception to handle that case.
Related issues
Associated revisions
[BUGFIX] Throw ViewNotFoundException if view could not be resolved
This improves the resolving of views by removing the canRender()
checks from ActionController::resolveView as discussed in #42176.
Besides this skips the creation of the obsolete NotFoundView in favor
of throwing a ViewNotFoundException.
This also adds overdue unit tests for the ActionController.
Change-Id: I27cba20836d695e46fe355bd1e4168a6fd86eb76
Fixes: #40888
Fixes: #40857
Related: #42176
Releases: 1.2
[TASK] Remove API annotation from View::canRender()
With #40888 View::canRender() is no longer called from within
ActionController::resolveView().
As the framework no longer relies on that method to exist the
@api annotation is removed.
Besides this marks EmptyView deprecated.
Change-Id: Ia10809aed5829ee2ed2308965a0f87cfca6d182b
Related: #40888
Related: #42176
Releases: 1.2
History
#1 Updated by Bastian Waidelich almost 3 years ago
- Status changed from New to Accepted
- Assigned To set to Bastian Waidelich
#2 Updated by Bastian Waidelich over 2 years ago
Unfortunately this is not as easy as it seemed..
If we throw an exception, one can't ignore the template and return content directly from an action.
This should be resolved with #42176 though.
#3 Updated by Gerrit Code Review over 2 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17072
#4 Updated by Karsten Dambekalns over 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100