TYPO3.Fluid

Hi Jeff,

sorry for the delay, the optional action argument makes perfect sense!
Only, there is an "issues" with that:
If I'd leave away the action argument, I'd expect the resulting URI not to contain the action at all, resulting in a call to the configured default action of the current plugin..

Actually, that's how I just implemented it for the formViewHelper and Uri-/Link-ActionViewHelpers in http://forge.typo3.org/attachments/1553/3981_tx_fluid_adjustments_v1.patch

If we want it to work the way you describe (no action -> use the current action) we'd need to modify the UriBuilder:
From:

if ($actionName !== NULL) {
    $controllerArguments['action'] = $actionName;
}

if ($actionName !== NULL) {
    $controllerArguments['action'] = $actionName;
} else {
    $controllerArguments['action'] = $this->request->getControllerActionName();
}

But I'm not sure if that really makes sense.. In the end you'd want to use the action link to create links to different actions?
Please correct me, if I'm missing something.

Hey Bastian,
For some reason I didn't get a notification on your first reply. Sorry for now responding sooner.

In my case, I'm using partials and a page browser view helper to display the same results from several different actions. When I navigate through the page browser, it makes sense to keep the current action, no matter what that action is. Perhaps I can address this by assigning a variable for the current action rather than leaving it out completely.

For most cases, your solution certainly makes more sense.

Thanks,
Jeff

Jeff Segars wrote:

Hey Jeff,

Sorry for now responding sooner.

No problem.

In my case, I'm using partials and a page browser view helper to display the same results from several different actions.

I see. It might work to set the action explicitly in your page browser view helper then.. Something like:

public function render(..., $action = NULL, ...) {
    if ($action === NULL) {
        $request = $this->controllerContext->getRequest();
        $action = $request->getControllerActionName();
    }
    ...

Perhaps I can address this by assigning a variable for the current action rather than leaving it out completely.

That's another solution. You can pass arguments to the partial like this:

<f:render partial="foo" arguments="{action: 'bar'}" />

For most cases, your solution certainly makes more sense.

Well, I've discussed it with Sebastian and Jochen and they think the same.

Thanks for the feedback