Task #42730

Story #41853: As an integrator I want an optimized setup

Importing Sitepackage or creating and creating admin is gone in the Setup

Added by Markus Goldbeck over 2 years ago. Updated over 2 years ago.

Status:Resolved Start date:2012-11-06
Priority:Must have Due date:
Assigned To:Karsten Dambekalns % Done:

100%
Category:-
Target version:-

Description

After the renaming changes

https://review.typo3.org/#/q/status:open+project:FLOW3/Packages/TYPO3.TYPO3,n,z

the step with importing or creating a site package and creating an admin user is gone

TYPO3.Setup.png (178 kB) Markus Goldbeck, 2012-11-06 15:26

TYPO3.Setup-1.png (126.4 kB) Markus Goldbeck, 2012-11-06 15:26

settings.txt Magnifier (41.2 kB) Markus Goldbeck, 2012-11-06 15:41

Related issues

related to TYPO3.Flow - Bug #28672: Inconsistent configuration overrides for packages Resolved 2011-08-02
duplicated by Base Distribution - Task #42740: Make all setup steps accessible again Closed

History

#1 Updated by Aske Ertmann over 2 years ago

http://git.typo3.org/FLOW3/Packages/TYPO3.TYPO3.git?a=blob;f=Configuration/Settings.yaml;h=cf20f40684df64b59d4ad5d5ce8d2b9da1d05751;hb=HEAD#l129 looks like it should though, could be a loading order problem but http://git.typo3.org/FLOW3/Packages/TYPO3.TYPO3.git?a=blob;f=composer.json;h=90514b90e74dfc6d4054b9d41b480caa4274e69d;hb=HEAD looks correct also..

So maybe a yaml configuration change (related to overwriting values) in Flow could have caused this, if any were merged recently?

#2 Updated by Markus Goldbeck over 2 years ago

Loading order PackagesStates.php
https://gist.github.com/4025059

#3 Updated by Markus Goldbeck over 2 years ago

output of ./flow configuration:show --type Settings

and on gist
https://gist.github.com/4025115

#4 Updated by Aske Ertmann over 2 years ago

  • Status changed from New to Accepted
  • Assigned To set to Karsten Dambekalns
  • % Done changed from 0 to 20

See the settings output gist on line 508 where the step order is. The second parameter in the loading order has not been overwritten as it previously did. Also title setting on line 532 should say "TYPO3 Neos Setup" and the final step configuration should say "TYPO3\Neos\Setup\Step\FinalStep" and not "TYPO3\Setup\Step\FinalStep"

#6 Updated by Karsten Dambekalns over 2 years ago

I think it's really an ordering issue. Before the Neos rename it would be

  • TYPO3.Setup
  • TYPO3.TYPO3

Now it is

  • TYPO3.Neos
  • TYPO3.Setup

Boom.

#7 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16328

#8 Updated by Christian Jul Jensen over 2 years ago

Please test the patch, it is WIP, but the it should be ok in terms of functionality.

#9 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16328

#10 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16328

#11 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16328

#12 Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16328

#13 Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16328

#14 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Accepted to Closed
  • Parent task set to #41853

Closing as duplicate of #42740

#15 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Closed to Accepted

Grrr. Wanted to close the other.

#16 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Accepted to Under Review

#17 Updated by Gerrit Code Review over 2 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16328

#18 Updated by Gerrit Code Review over 2 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16328

#19 Updated by Gerrit Code Review over 2 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16328

#20 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 20 to 100

Also available in: Atom PDF