Bug #44280

Git core:migration check for applied version fail

Added by Tarcisio Fedrizzi over 2 years ago. Updated over 2 years ago.

Status:Resolved Start date:2013-01-03
Priority:Should have Due date:
Assigned To:Karsten Dambekalns % Done:

100%
Category:- Migrations -
Target version:TYPO3 Flow Base Distribution - 2.0
PHP Version: Complexity:no-brainer
Has patch:Yes Affected Flow version:(any)

Description

When I migrate a package for the changes introduced in the code I get the following error:

Applying TYPO3.FLOW3-201201261636
fatal: Invalid object name 'Migration'.
  Migrating Package.Name
    No changes were committed.

  -------------------------------------------------------------------------------
   Notes
  -------------------------------------------------------------------------------
  * \TYPO3\FLOW3\MVC\Web\RequestBuilder does not exist anymore. If you need to
    create requests, do "new ActionRequest($parentRequest)".
...

I tracked down the problem to the migration script Git.php. The problem is in the
grep parameter specified without the = operator.
The attached patch solves the problem.

migration-applied-check.patch Magnifier (675 Bytes) Tarcisio Fedrizzi, 2013-01-03 11:07

Associated revisions

Revision a898458d
Added by Karsten Dambekalns over 2 years ago

[BUGFIX] Fix git error with "core:migrate --status" command

Obviously there are some different ways git handles the --grep option
to the log command. This changes should make it work everywhere, and
uses the syntax actually spelled out in the help text.

Change-Id: Ie8689158d30732e537f74c09d55141e20510ce4e
Fixes: #44280
Releases: master, 2.0, 1.1

Revision 1e14c97c
Added by Karsten Dambekalns over 2 years ago

[BUGFIX] Fix git error with "core:migrate --status" command

Obviously there are some different ways git handles the --grep option
to the log command. This changes should make it work everywhere, and
uses the syntax actually spelled out in the help text.

Change-Id: Ie8689158d30732e537f74c09d55141e20510ce4e
Fixes: #44280
Releases: master, 2.0, 1.1

Revision dee953cb
Added by Karsten Dambekalns over 2 years ago

[BUGFIX] Fix git error with "core:migrate --status" command

Obviously there are some different ways git handles the --grep option
to the log command. This changes should make it work everywhere, and
uses the syntax actually spelled out in the help text.

Change-Id: Ie8689158d30732e537f74c09d55141e20510ce4e
Fixes: #44280
Releases: master, 2.0, 1.1

History

#1 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from New to Needs Feedback
  • Assigned To set to Karsten Dambekalns

What Git version are you using? And under what OS/shell combination?

#2 Updated by Tarcisio Fedrizzi over 2 years ago

Here are the info:
- GIT version: 1.7.2.5
- OS: Debian Squeeze 6.0
- Shell: /bin/bash version 4.1.5

About the grep option the manpage for git says:

--grep=<pattern>
           Limit the commits output to ones with log message that matches the specified pattern (regular expression).

I've checked more recent version (1.8.1) manpage and the value for the grep option is still specified to be used with the = operator.

#3 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Needs Feedback to Accepted
  • Target version set to 2.0

#4 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Accepted to Under Review

#5 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF