Bug #44409

Package management must not call updateSchema()

Added by Karsten Dambekalns over 2 years ago. Updated over 2 years ago.

Status:Resolved Start date:2013-01-09
Priority:Must have Due date:
Assigned To:Karsten Dambekalns % Done:

100%
Category:-
Target version:Base Distribution - 1.0 beta 1

Description

When a package is activated or deactivated through the package management feature in the Administration module, updateSchema() is called. This should never be done, if schema changes are needed, the use of migrations is in order (and that is best done elsewhere).

Associated revisions

Revision 28650fee
Added by Karsten Dambekalns over 2 years ago

[BUGFIX] Remove use of updateSchema in package management

Change-Id: Ic42b3befdd16c63a46ca2fb159b4e58432fb613f
Fixes: #44409

History

#1 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from New to Under Review
  • Assigned To set to Karsten Dambekalns

#2 Updated by Soren Malling over 2 years ago

Are you thinking about a separate module taking care of databaseschema (migrations, creating new columns etc?)

Or where do you want this to be moved? A different way could be to run the migrations first? And if updateSchema is not to be used, why not remove it?

#3 Updated by Karsten Dambekalns over 2 years ago

Soren Malling wrote:

Are you thinking about a separate module taking care of databaseschema (migrations, creating new columns etc?)

Unless we integrate package import to some GUI again, it should not be anywhere.

Or where do you want this to be moved? A different way could be to run the migrations first? And if updateSchema is not to be used, why not remove it?

With composer and deployments and all that we should think about having a GUI for this in Neos at all again. At least at the current point it seems only half-way done.

On updateSchema() - in case no migrations are available, it can be helpful. If you know what you are doing, it can be helpful. But in any case - a proper migration is always preferable.

#4 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF