Bug #44470
Content elements in wrong column in page module
| Status: | Resolved | Start date: | 2013-01-13 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Oliver Hader | % Done: | 100% |
|
| Category: | Backend User Interface | Spent time: | - | |
| Target version: | 4.5.23 | |||
| TYPO3 Version: | 4.5 | Is Regression: | No | |
| PHP Version: | 5.3 | Sprint Focus: | ||
| Complexity: | easy |
Description
If working on workspaces, it might happen that content elements just appear in the wrong column.
The reason is, that live(!) content elements are selected using a specific column value and then are overlays by workspace data.
If the column value has been modified in a workspace, this is currently just ignored during rendering.
Subtasks
Related issues
Associated revisions
[BUGFIX] Content elements in wrong column in page module
If working on workspaces, it might happen that content elements
just appear in the wrong column. The reason is, that live(!)
content elements are selected using a specific column value and
then are overlaid with workspace data.
If the column value has been modified in a workspace, this is
currently just ignored during rendering.
Change-Id: I9eccc2ff5b7220544cd28ee6de8f55453c04a5d1
Fixes: #44470
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17468
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
[BUGFIX] Content elements in wrong column in page module
If working on workspaces, it might happen that content elements
just appear in the wrong column. The reason is, that live(!)
content elements are selected using a specific column value and
then are overlaid with workspace data.
If the column value has been modified in a workspace, this is
currently just ignored during rendering.
Change-Id: I6669ea096d93269591727b20d92ef5250898900f
Fixes: #44470
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17496
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
[BUGFIX] Content elements in wrong column in page module
If working on workspaces, it might happen that content elements
just appear in the wrong column. The reason is, that live(!)
content elements are selected using a specific column value and
then are overlaid with workspace data.
If the column value has been modified in a workspace, this is
currently just ignored during rendering.
Change-Id: I148ca1b023226f2f99417b3baf238b72346e721f
Fixes: #44470
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17497
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
[BUGFIX] Content elements in wrong column in page module
If working on workspaces, it might happen that content elements
just appear in the wrong column. The reason is, that live(!)
content elements are selected using a specific column value and
then are overlaid with workspace data.
If the column value has been modified in a workspace, this is
currently just ignored during rendering.
Change-Id: I148ca1b023226f2f99417b3baf238b72346e721f
Fixes: #44470
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17637
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
History
#1 Updated by Gerrit Code Review over 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17468
#2 Updated by Gerrit Code Review over 2 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17468
#3 Updated by Gerrit Code Review over 2 years ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/17496
#4 Updated by Oliver Hader over 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 2abebe67414dbff9b07975d583d1619a78a9fbc5.
#5 Updated by Gerrit Code Review over 2 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/17497
#6 Updated by Gerrit Code Review over 2 years ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/17637
#7 Updated by Gerrit Code Review over 2 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at https://review.typo3.org/17638
#8 Updated by Jigal van Hemert over 2 years ago
- Status changed from Under Review to Resolved
Applied in changeset 1da948f9ad6ed5dc751cb5439909d1335072fbb7.
#9 Updated by Oliver Hader over 2 years ago
Patch for TYPO3_4-6 has been dropped due to EOL
#10 Updated by Thorsten Kahler almost 2 years ago
- Is Regression set to No
#11 Updated by Jigal van Hemert almost 2 years ago
@Thorsten : the patches you mention do not solve this issue, nor do they solve the problem with the sorting buttons. This particular patch solved the problem that the content elements from the live workspace were first retrieved for each column and after that the workspace overlay was applied. If the column was moved to another column in the workspace it was displayed in the column where it was in the live workspace. This patch solves that by first retrieving the content elements from all columns, applying the workspace overlay and then distribute them to the columns.
The problem in getResult is that it was designed for use in a single column. The solution in https://review.typo3.org/25001 may not be perfect yet, but it will move the handling of the sorting links data to the right place.
#12 Updated by Thorsten Kahler almost 2 years ago
Jigal van Hemert wrote:
If move placeholders are created when content elements are moved between columns the original code ofThis particular patch solved the problem that the content elements from the live workspace were first retrieved for each column and after that the workspace overlay was applied. If the column was moved to another column in the workspace it was displayed in the column where it was in the live workspace. This patch solves that by first retrieving the content elements from all columns, applying the workspace overlay and then distribute them to the columns.
PageLayoutView works flawless because
- placeholder records are fetched in the right column
- moved records are detected when applying the WS overlay
If changing the colPos is handled as move operation this doesn't only solve the BE display issue #44470 but also fixes FE preview.
The problem in getResult is that it was designed for use in a single column. The solution in https://review.typo3.org/25001 may not be perfect yet, but it will move the handling of the sorting links data to the right place.
The (IMO) "perfect" solution would be to use move placeholders consistently. Then there would be no problem with getResult().
Please try to change the column via drag-n-drop and via BE form to see the difference: drag-n-drop already creates a move placeholder.