Bug #44670
JS in Welcome Package broken
| Status: | Resolved | Start date: | 2013-01-20 | |
|---|---|---|---|---|
| Priority: | Could have | Due date: | ||
| Assigned To: | Karsten Dambekalns | % Done: | 100% |
|
| Category: | - | |||
| Target version: | - | |||
| Affected Flow version: | Flow 2.0.0 beta 1 |
Description
Hi,
I've just installed the 2.0b1 in a VM and recognized that the javascript in the welcome package seems to be broken. The mootools core v1.2.2 seems to be buggy as it does not return the first h2 element via element.getFirst() but the ".tab" div itself, which results in non object error after element.getFirst('h2). It also results in a broken layout, as the "tab-*" css classes are not correctly assigned so that the stylesheets in the Styles.css don't apply correctly.
Just replace the mootools library with the latest one and everthing seems to be fine again. I used the latest mootools-core-1.4.5-full-compat-yc.js from the mootools website.
This is just cosmetical, I know, but normaly it's the first part of Flow every new user sees.
Regards,
Axel
Associated revisions
[BUGFIX] Switch welcome site to jQuery for consistency
The welcome site now also uses jQuery as JavaScript library.
Additionally folder names were adapted to match the best
practice proposal we have.
Change-Id: I0038185fca9a02a10cf6e36193a66f1b8985d551
Fixes: #44670
Releases: master, 2.0, 1.1
[BUGFIX] Switch welcome site to jQuery for consistency
The welcome site now also uses jQuery as JavaScript library.
Additionally folder names were adapted to match the best
practice proposal we have.
Change-Id: I0038185fca9a02a10cf6e36193a66f1b8985d551
Fixes: #44670
Releases: master, 2.0, 1.1
[BUGFIX] Switch welcome site to jQuery for consistency
The welcome site now also uses jQuery as JavaScript library.
Additionally folder names were adapted to match the best
practice proposal we have.
Change-Id: I0038185fca9a02a10cf6e36193a66f1b8985d551
Fixes: #44670
Releases: master, 2.0, 1.1
History
#1 Updated by Karsten Dambekalns over 2 years ago
- Project changed from TYPO3.Flow to TYPO3.Welcome
- Status changed from New to Needs Feedback
- Assigned To set to Karsten Dambekalns
What browser are you using? It works fine here, with Chrome…
#2 Updated by Adrian Föder over 2 years ago
Rafael http://forge.typo3.org/users/38109 just came up with it and I came with the following conclusion:
On Firefox 18, MooTools 1.2 behaves the following:
1<div> 2 <div class="tabs"> 3 <div class="tab">one</div> 4 <div class="tab">two</div> 5 </div> 6</div>1document.getElements('.tab') -> [div.tabs, div.tab, div.tab]
This is incorrect as it must of course only return the actual ".tab" items.
See this for a comparison: http://jsfiddle.net/aAnjt/
In Browsers < FF 18 this does not happen; so does not Mootools 1.4.
I'd strongly recommend to update to MooTools 1.4; or, if you like, to jQuery (however I personally prefer MooTools ;)
#3 Updated by Axel Böswetter over 2 years ago
Sorry for the late reply. I am using FF 18 as mentioned above.
#4 Updated by Gerrit Code Review over 2 years ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17700
#5 Updated by Gerrit Code Review over 2 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18391
#6 Updated by Gerrit Code Review over 2 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18391
#7 Updated by Christian Müller over 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 27b3e27f12d1ad472a8c5a9f6732f8a864a20c55.
#8 Updated by Gerrit Code Review over 2 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at https://review.typo3.org/19050
#9 Updated by Gerrit Code Review over 2 years ago
Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19051
#10 Updated by Christian Müller over 2 years ago
- Status changed from Under Review to Resolved
Applied in changeset 6d0b866da48893e2a6ea00b8b6cde100bbd68ac5.