Task #44683

Story #41101: As user, I want a well-working content editing (Bugfix Story)

Image upload of some filetypes is not working, button "Upload!" is disfunctional

Added by Christopher Hlubek over 2 years ago. Updated over 2 years ago.

Status:Resolved Start date:
Priority:Should have Due date:
Assigned To:Christopher Hlubek % Done:

100%
Category:- Spent time: -
Target version:-

Screen_Shot_2013-01-21_at_3.35.04_PM.png - Upload image (38.7 kB) Mattias Nilsson, 2013-01-21 15:40

Screen_Shot_2013-01-21_at_3.34.23_PM.png - Succesfully uploaded image (113.5 kB) Mattias Nilsson, 2013-01-21 15:40

Associated revisions

Revision 076b0c05
Added by Christopher Hlubek over 2 years ago

[BUGFIX] Show image upload errors and disable upload for wrong types

When selecting images that do not match the accepted filetype of the
uploader an error is shown and the upload button is disabled.

Additionally the image extensions "jpeg" and "gif" are supported.

Change-Id: I7b162b32030e9e264dc9be9567f853a17b29c372
Resolves: #44683

History

#1 Updated by Christopher Hlubek over 2 years ago

  • Priority changed from Should have to Must have

#2 Updated by Mattias Nilsson over 2 years ago

Hi Christopher,

I have just tried to upload an image in the latest master from GIT. It worked out perfectly for me using the latest version of Firefox and Google Chrome.

Take a look a the attached screenshot I made.

/Mattias

#3 Updated by Christopher Hlubek over 2 years ago

Hi Mattias,

thx I'll have a look at the problem again. The "Upload!" button just didn't work because the file list was empty on upload after choosing an image.

#4 Updated by Christopher Hlubek over 2 years ago

  • Subject changed from Image upload is not working, button "Upload!" is disfunctional to Image upload of some filetypes is not working, button "Upload!" is disfunctional
  • Priority changed from Must have to Should have

Well it was my image extension (.jpeg) that was not accepted and did not show any visible error. So I rephrased the issue description.

With another image the upload worked as expected.

#5 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17648

#6 Updated by Christopher Hlubek over 2 years ago

  • Status changed from New to Under Review

#7 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17648

#8 Updated by Christopher Hlubek over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:076b0c05d4b5e36194285838335260a8c02bd540.

Also available in: Atom PDF