Bug #44889
Format urlencode viewhelper should work with objects that implement __toString
| Status: | Resolved | Start date: | 2013-01-28 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | - | % Done: | 100% |
|
| Category: | - | |||
| Target version: | - | |||
| Has patch: | No | Affected Flow version: | (any) |
Description
currently a check for is_string prevents format.urlencode to work with objects that implements __toString
Associated revisions
[!!!][BUGFIX] urlencode viewhelper accepts objects with __toString
This fixes a problem with the urlencode view helper. If you pass it an
object with _toString() method – for example an URI object – it is
returned as is. Now the view helper additionally checks for a
_toString() method.
This change is breaking if you rely on the viewhelper to return
values that are not a string or an object with __toString.
The viewhelper will now throw an exception in this case.
Change-Id: Ibf53dab49b47f8a73870dc53b8e6380b38cd01ec
Fixes: #44889
Releases: 2.0, master
[!!!][BUGFIX] urlencode viewhelper accepts objects with __toString
This fixes a problem with the urlencode view helper. If you pass it an
object with _toString() method – for example an URI object – it is
returned as is. Now the view helper additionally checks for a
_toString() method.
This change is breaking if you rely on the viewhelper to return
values that are not a string or an object with __toString.
The viewhelper will now throw an exception in this case.
Change-Id: Ibf53dab49b47f8a73870dc53b8e6380b38cd01ec
Fixes: #44889
Releases: 2.0, master
History
#1 Updated by Gerrit Code Review over 2 years ago
- Status changed from Accepted to Under Review
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763
#2 Updated by Gerrit Code Review over 2 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763
#3 Updated by Christian Müller over 2 years ago
Note: This is the same in other format viewhelpers as well, so should probably be changed there as well to be consistent.
#4 Updated by Gerrit Code Review over 2 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763
#5 Updated by Gerrit Code Review over 2 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763
#6 Updated by Gerrit Code Review over 2 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763
#7 Updated by Gerrit Code Review over 2 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763
#8 Updated by Gerrit Code Review over 2 years ago
Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763
#9 Updated by Gerrit Code Review over 2 years ago
Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763
#10 Updated by Gerrit Code Review over 2 years ago
Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763
#11 Updated by Gerrit Code Review over 2 years ago
Patch set 11 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17763
#12 Updated by Sebastian Kurfuerst over 2 years ago
- Status changed from Under Review to Resolved
#13 Updated by Gerrit Code Review over 2 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19137
#14 Updated by Robert Lemke over 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b10d6f6b492c2241f73891760b8603bdc2d64df6.