Feature #45264

Add Flow caching for Doctrine metadata and query caches

Added by Marc Neuhaus over 2 years ago. Updated over 2 years ago.

Status:Resolved Start date:2013-02-08
Priority:Should have Due date:
Assigned To:Karsten Dambekalns % Done:

100%
Category:Persistence
Target version:TYPO3 Flow Base Distribution - 2.0
PHP Version: Complexity:
Has patch:No

Description

During a little investigation i found FlowAnnotationDriver::loadMetadataForClass to produce up to 60% of execution time in Production context.

Since this method only loads 'static' metadata (correct me if i'm wrong) this seems to be perfect to be cached.

Related issues

related to TYPO3.Flow - Task #47346: Configuration schema for doctrine cacheImplementation sti... Resolved 2013-04-18

Associated revisions

Revision 5e5ebf31
Added by Karsten Dambekalns over 2 years ago

[BUGFIX] Add Flow-Doctrine cache adapter

This adds a cache adapter for Doctrine. It is used for the Doctrine ORM
metadata and query cache instead of the ArrayCache used until now.

Until now the cache implementations of Doctrine that could be configured
were not usable. This change fixes that, so that actually a cache for
metadata and query caching is used.

Change-Id: I37406667197f38f66ae778254307f09fab2b0b95
Fixes: #45264
Releases: master, 2.0

Revision 660a5458
Added by Karsten Dambekalns over 2 years ago

[BUGFIX] Add Flow-Doctrine cache adapter

This adds a cache adapter for Doctrine. It is used for the Doctrine ORM
metadata and query cache instead of the ArrayCache used until now.

Until now the cache implementations of Doctrine that could be configured
were not usable. This change fixes that, so that actually a cache for
metadata and query caching is used.

Change-Id: I37406667197f38f66ae778254307f09fab2b0b95
Fixes: #45264
Releases: master, 2.0

Revision e5933c38
Added by Karsten Dambekalns over 2 years ago

[BUGFIX] Add Flow-Doctrine cache adapter

This adds a cache adapter for Doctrine. It is used for the Doctrine ORM
metadata and query cache instead of the ArrayCache used until now.

Until now the cache implementations of Doctrine that could be configured
were not usable. This change fixes that, so that actually a cache for
metadata and query caching is used.

Change-Id: I37406667197f38f66ae778254307f09fab2b0b95
Fixes: #45264
Releases: master, 2.0

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18105

#2 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18105

#3 Updated by Marc Neuhaus over 2 years ago

Some first tests result in up to a solid second less execution time on a medium size project, in Dev and Production mode:

http://dl.dropbox.com/u/314491/Screenshots/i2useikmnljq.png

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18105

#5 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18105

#6 Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18105

#7 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18877

#8 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18877

#9 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18877

#10 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18883

#11 Updated by Karsten Dambekalns over 2 years ago

  • Subject changed from Add Caching to FlowAnnotationDriver::loadMetadataForClass to Add Flow caching for Doctrine metadata and query caches
  • Category set to Persistence
  • Assigned To set to Karsten Dambekalns
  • Target version set to 2.0

The latest change (https://review.typo3.org/18883) leads to this improvement:

#12 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18883

#13 Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18883

#14 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#15 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19061

#16 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch composer has been pushed to the review server.
It is available at https://review.typo3.org/19356

#17 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Under Review to Resolved

#18 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19061

#19 Updated by Karsten Dambekalns over 2 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF