Feature #45431

Work Package #45020: Content Editing Stability and Features

Icon location for Node Types in Neos shouldn't be fixed to Neos package

Added by Christian Müller over 2 years ago. Updated 9 months ago.

Status:Closed Start date:2013-02-13
Priority:Should have Due date:
Assigned To:- % Done:

100%

Category:-
Target version:Base Distribution - 1.0 beta 1

Description

Allow usage of resource uris for icons to allow usage from other packages.


Related issues

related to TYPO3.Neos - Bug #47752: Changes list for workspace has broken type icons Resolved 2013-04-30

Associated revisions

Revision a223e173
Added by Aske Ertmann over 2 years ago

[TASK] Adjust to node icon resource path change

Change-Id: I01ba7141d9d70b206f7dd667aed07f5c832e5a35
Related: #45431

Revision d4bc0ee5
Added by Karsten Dambekalns over 2 years ago

[BUGFIX] Changes list for workspace has broken icons

Change-Id: Ib9705dfd341119f3e8e79cc43583ce63a2207d55
Fixes: #47752
Related: #45431

Revision 9462e475
Added by Berit Hlubek about 2 years ago

[TASK] Use FontAwesome icons in ContentAdd and PageTree

- adjusted styling
- use class names in NodeType configuration
- use NodeType classes in PageTree

Change-Id: Icc7bdf9f8f9ebe15876a68d32ecdb20c2b68bbb3
Related: #45431
Reviewed-on: https://review.typo3.org/21895
Reviewed-by: Christopher Hlubek
Tested-by: Christopher Hlubek
Reviewed-by: Berit Hlubek
Tested-by: Berit Hlubek

Revision 47db39a5
Added by Aske Ertmann about 2 years ago

[BUGFIX] Remove remaining usages of old icon structure

Change-Id: I0c39de3c352fa9942cb5c9f679b41273f64c8569
Related: #45431
Reviewed-on: https://review.typo3.org/21919
Reviewed-by: Aske Ertmann
Tested-by: Aske Ertmann
Reviewed-by: Tim Kandel
Tested-by: Tim Kandel
Reviewed-by: Berit Hlubek
Tested-by: Berit Hlubek

History

#1 Updated by Aske Ertmann over 2 years ago

  • Tracker changed from Bug to Feature

#2 Updated by Aske Ertmann over 2 years ago

  • Target version set to 1.0 beta 1

#3 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19474

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19474

#5 Updated by Aske Ertmann over 2 years ago

  • Status changed from New to Under Review
  • Assigned To set to Aske Ertmann
  • % Done changed from 0 to 90

#6 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19474

#7 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19474

#8 Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21081

#9 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21081

#10 Updated by Bastian Waidelich about 2 years ago

Obviously I agree to the goal of this issue. But we should consider following challenges:
  1. We currently have two "sets" of icons: light and dark - will there be more? does everybody has to provide two icons?
  2. What about different sizes? in different representations (e.g. node tree vs workspace module or for different screens) we might want to display icons in a different resolution

I think in the long run we should go for single colored vector icons throughout the Neos backend as this would solve both issues above and some more.

I'm wondering if we could go this path already now instead of introducing a (breaking?) change that is only an intermediate solution. What about including (configurable) icon fonts and some (dynamic) CSS? That would also simplify the markup from:

1<div class="neos-content-new-selecttype-button">
2  <a rel="typo3:TYPO3.Neos.NodeTypes:Headline" class="neos-content-new">
3    <script id="metamorph-86-start" type="text/x-placeholder"></script>
4      <img src="Images/Icons/White/text_letter_t_icon-16.png">
5    <script id="metamorph-86-end" type="text/x-placeholder"></script>
6    Headline
7  </a>
8 </div>

to just:

1<div class="neos-content-new-selecttype-button">
2  <a rel="typo3:TYPO3.Neos.NodeTypes:Headline" class="neos-content-new">
3    Headline
4  </a>
5 </div>

#11 Updated by Karsten Dambekalns almost 2 years ago

  • Status changed from Under Review to Accepted

#12 Updated by Aske Ertmann almost 2 years ago

  • Status changed from Accepted to Resolved
  • Assigned To deleted (Aske Ertmann)
  • % Done changed from 90 to 100

#13 Updated by Christian Müller almost 2 years ago

  • Status changed from Resolved to Closed

#14 Updated by Christian Müller almost 2 years ago

  • Status changed from Closed to Resolved

#15 Updated by Aske Ertmann 9 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF