Task #45531
Work Package #45020: Content Editing Stability and Features
In Backend, handle exceptions more gracefully if possible
| Status: | Closed | Start date: | 2013-02-16 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assigned To: | Tim Kandel | % Done: | 100% |
|
| Category: | - | |||
| Target version: | Base Distribution - 1.0 beta 1 |
Description
As soon as an exception occurs, it's displayed and the whole backend halts with no way to escape.
As an example, we removed a declaration in TypoScript regarding the plugin implementations of TYPO3.MailForm; such a plugin node was however still present. This resulted in the correct exception
#1332493995: The TypoScript object at path "page<TYPO3.Neos.ContentTypes:Page>/body<TYPO3.TypoScript:Template>/sections/main<TYPO3.Neos.ContentTypes:Section>/default<TYPO3.TypoScript:Matcher>/element<TYPO3.Neos.ContentTypes:Section.Default>/itemRenderer<TYPO3.TypoScript:Case>/default<TYPO3.TypoScript:Matcher>/element<TYPO3.MailForm:Plugin>" could not be rendered: Missing implementation class name for "TYPO3.MailForm:Plugin". Add @class in your TypoScript configuration. (More information)
Although this is correct; this exception should rather occur as an inline note or something like that; giving the opportunity to finally delete the node or whatever.
Related issues
Associated revisions
[TASK] Change the TS exception handling to allow more options
Adjusts the PluginImplementation and the ContentElementViewHelper to use the
newly implemented Exception handling to allow removing the element if an
error occured.
Change-Id: I608dc27c712229c52932c46df7f7dee9223ee4a4
Related: #45531
Reviewed-on: https://review.typo3.org/22031
Reviewed-by: Tim Kandel
Tested-by: Tim Kandel
Reviewed-by: Sebastian Kurfuerst
Tested-by: Sebastian Kurfuerst
[BUGFIX] Graceful degradation of broken content elements
If content elements cannot be rendered for some reason, an error message
is displayed instead of the actual content. The broken elements can
still be (un)hidden, copy-pasted, … and even published.
Some errors are not yet covered yet, like not existing Node-Types.
In this case the error message is displayed without the option to hide,
remove, cut or copy the broken element.
There is already a request for this Feature #52511.
The css-styles of the Neos backend do not apply to published, broken
content elements, but can be customized.
The TypoScript object type TYPO3.Neos:Template declares the
@exceptionHandler property to handle rendering exceptions with a special
handler that wraps nodes with the content element wrapping services.
Resolves: #45531
Change-Id: Iddd7b254e352b7960919bfc0c25321e2a38660e4
Reviewed-on: https://review.typo3.org/24239
Reviewed-by: Christopher Hlubek
Tested-by: Christopher Hlubek
Reviewed-by: Sebastian Kurfuerst
Tested-by: Sebastian Kurfuerst
History
#1 Updated by Aske Ertmann over 2 years ago
- Status changed from New to Accepted
We should handle these exceptions with a default error text with proper information about the issue, there is however an issue about when a real exception should be thrown and when it should be handled gracefully. I'd say if it's not live workspace, handle the exception gracefully. It would be very nice if we could reference a system logging module for the error description, but we need to create that before we can do so.
#2 Updated by Tim Kandel about 2 years ago
- Assigned To set to Tim Kandel
#3 Updated by Gerrit Code Review about 2 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20866
#4 Updated by Tim Kandel about 2 years ago
- Status changed from Accepted to Under Review
- % Done changed from 0 to 100
#5 Updated by Adrian Föder about 2 years ago
- Tracker changed from Bug to Task
- Category deleted (
UI)
#6 Updated by Karsten Dambekalns almost 2 years ago
- Status changed from Under Review to Resolved
#7 Updated by Gerrit Code Review almost 2 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24239
#8 Updated by Gerrit Code Review almost 2 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24224
#9 Updated by Gerrit Code Review almost 2 years ago
Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24224
#10 Updated by Gerrit Code Review almost 2 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24239
#11 Updated by Gerrit Code Review almost 2 years ago
Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24224
#12 Updated by Gerrit Code Review almost 2 years ago
Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24224
#13 Updated by Gerrit Code Review almost 2 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24239
#14 Updated by Gerrit Code Review almost 2 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24239
#15 Updated by Gerrit Code Review almost 2 years ago
Patch set 11 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24224
#16 Updated by Gerrit Code Review almost 2 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24239
#17 Updated by Gerrit Code Review almost 2 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24239
#18 Updated by Gerrit Code Review almost 2 years ago
Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24239
#19 Updated by Gerrit Code Review almost 2 years ago
Patch set 12 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24224
#20 Updated by Gerrit Code Review almost 2 years ago
Patch set 13 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24224
#21 Updated by Gerrit Code Review almost 2 years ago
Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24239
#22 Updated by Gerrit Code Review almost 2 years ago
Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24239
#23 Updated by Gerrit Code Review almost 2 years ago
Patch set 14 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24224
#24 Updated by Anonymous almost 2 years ago
- Status changed from Under Review to Resolved
Applied in changeset b5b28414274cfb00c7b378847f8ea1e60c6f93f5.
#25 Updated by Aske Ertmann 9 months ago
- Status changed from Resolved to Closed