Bug #46290

Remove unnecessary checks for file_exists and is_dir in FileMonitor

Added by Rens Admiraal over 2 years ago. Updated over 2 years ago.

Status:Resolved Start date:2013-03-14
Priority:Should have Due date:
Assigned To:Rens Admiraal % Done:

100%
Category:-
Target version:-
Affected Flow version:Git master

Description

The FileMonitor is massively slow on Windows, this is just because file access on windows from PHP is slow. Therefor unnecessary calls to the filesystem should be prevented.

Associated revisions

Revision 203534c8
Added by Rens Admiraal over 2 years ago

[BUGFIX] Remove unneeded filesystem calls

This change removes a call to is_dir in the FileMonitor
which is duplicate as the ReadDirectoryRecursively does
exactly the same and throws an error in this case.

Also 2 calls to file_exists are removed as they're not
necessary at this point as filemtime() will just return
FALSE if something goes wrong.

Change-Id: I93c624cf5d5684d0fe33e8fdf348c535b742d54a
Resolves: #46290
Releases: master, 2.0

Revision df077213
Added by Rens Admiraal over 2 years ago

[BUGFIX] Remove unneeded filesystem calls

This change removes a call to is_dir in the FileMonitor
which is duplicate as the ReadDirectoryRecursively does
exactly the same and throws an error in this case.

Also 2 calls to file_exists are removed as they're not
necessary at this point as filemtime() will just return
FALSE if something goes wrong.

Change-Id: I93c624cf5d5684d0fe33e8fdf348c535b742d54a
Resolves: #46290
Releases: master, 2.0

Revision ab5f67c4
Added by Rens Admiraal over 2 years ago

[BUGFIX] Remove unneeded filesystem calls

This change removes a call to is_dir in the FileMonitor
which is duplicate as the ReadDirectoryRecursively does
exactly the same and throws an error in this case.
Also 2 calls to file_exists are removed as they're not
necessary at this point as filemtime() will just return
FALSE if something goes wrong.

Change-Id: I93c624cf5d5684d0fe33e8fdf348c535b742d54a
Resolves: #46290
Releases: master, 2.0

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18912

#2 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18912

#3 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/18950

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18912

#5 Updated by Rens Admiraal over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:203534c808fc5514829692be63c031ed2126bca9.

#6 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/18950

#7 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch composer has been pushed to the review server.
It is available at https://review.typo3.org/19357

#8 Updated by Rens Admiraal over 2 years ago

  • Status changed from Under Review to Resolved

Applied in changeset commit:df0772139861a596953d0994fb5b103e40a11ce7.

#9 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 3 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/18950

#10 Updated by Rens Admiraal over 2 years ago

  • Status changed from Under Review to Resolved

Applied in changeset commit:ab5f67c48ab44a96d29aab0f5b08a0b9e8bccdc7.

Also available in: Atom PDF