Bug #46337
Remove (costly) file_exists calls in class loading
| Status: | Resolved | Start date: | 2013-03-15 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Christian Müller | % Done: | 100% |
|
| Category: | - | |||
| Target version: | - | |||
| PHP Version: | Complexity: | |||
| Has patch: | No | Affected Flow version: | (any) |
Associated revisions
[TASK] Use include with shutup instead of file_exists
This change uses include with shutup operator instead of file_exists
checks for optimized performance.
Change-Id: Ia2ddef625db70d8c985526978b6d83cebbe4d90f
Fixes: #46337
Releases: master, 2.0
[TASK] Use include with shutup instead of file_exists
This change uses include with shutup operator instead of file_exists
checks for optimized performance.
Change-Id: Ia2ddef625db70d8c985526978b6d83cebbe4d90f
Fixes: #46337
Releases: master, 2.0
[TASK] Use include with shutup instead of file_exists
This change uses include with shutup operator instead of file_exists
checks for optimized performance.
Change-Id: Ia2ddef625db70d8c985526978b6d83cebbe4d90f
Fixes: #46337
Releases: master, 2.0
History
#1 Updated by Gerrit Code Review over 2 years ago
- Status changed from Accepted to Under Review
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18873
#2 Updated by Gerrit Code Review over 2 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18873
#3 Updated by Christian Müller over 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 70a092b9b7bfa4ae904bbc027135fec7f2df00d5.
#4 Updated by Norbert Sendetzky over 2 years ago
My tests have shown that using file_exists() is faster than using @include when the file doesn't exist. As this is the most common case when several include paths are available, it's likely that this patch will slow down class loading instead of improving it.
#5 Updated by Gerrit Code Review over 2 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/19062
#6 Updated by Christian Müller over 2 years ago
- Status changed from Under Review to Resolved
Applied in changeset 0a84926a859cd077c3c9d6f2744c01552805c045.
#7 Updated by Gerrit Code Review over 2 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch composer has been pushed to the review server.
It is available at https://review.typo3.org/19359
#8 Updated by Christian Müller over 2 years ago
- Status changed from Under Review to Resolved
Applied in changeset db967c8b78a39a14cccae90b085dcf7320e8bbb0.