Bug #46862
generateUUID can be broken by seeding mt_rand
| Status: | Resolved | Start date: | 2013-04-02 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Christian Jul Jensen | % Done: | 100% |
|
| Category: | Utility | |||
| Target version: | - | |||
| PHP Version: | Complexity: | |||
| Has patch: | No | Affected Flow version: | Git master |
Description
If any code seeds mt_rand, the generated uuids will no longer be random, and can result in collisions on subsequent runs
Related issues
Associated revisions
[BUGFIX] generateUUID can be broken by seeding mt_rand
Use randomizer which cannot be seeded / configured by userspace code.
Change-Id: I1237fdfbee75cbfca2f2082cf30a69383dbc7fd5
Resolves: #46862
Releases: master, 2.0
[BUGFIX] generateUUID can be broken by seeding mt_rand
Use randomizer which cannot be seeded / configured by userspace code.
Change-Id: I1237fdfbee75cbfca2f2082cf30a69383dbc7fd5
Resolves: #46862
Releases: master, 2.0
[BUGFIX] generateUUID() creates uppercase characters in UUIDs
The UUIDs generated by that method were always lowercase, now they are
uppercase (since change I1237fdfbee75cbfca2f2082cf30a69383dbc7fd5). As
soon as you do a case-sensitive comparison on those UUIDs as strings,
this will now break, even if the UUIDs are the same semantically.
This change makes them lowercase again.
Change-Id: I0ec62f8710cc3c84fb726e3b08e6e08fc1638e39
Fixes: #47534
Related: #46862
Releases: master, 2.0
[BUGFIX] generateUUID() creates uppercase characters in UUIDs
The UUIDs generated by that method were always lowercase, now they are
uppercase (since change I1237fdfbee75cbfca2f2082cf30a69383dbc7fd5). As
soon as you do a case-sensitive comparison on those UUIDs as strings,
this will now break, even if the UUIDs are the same semantically.
This change makes them lowercase again.
Change-Id: I0ec62f8710cc3c84fb726e3b08e6e08fc1638e39
Fixes: #47534
Related: #46862
Releases: master, 2.0
History
#1 Updated by Gerrit Code Review over 2 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19515
#2 Updated by Gerrit Code Review over 2 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19515
#3 Updated by Gerrit Code Review over 2 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19515
#4 Updated by Gerrit Code Review over 2 years ago
Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/20103
#5 Updated by Christian Jul Jensen over 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset e8f8e08e0885419651c494aff6ae804e8bf643b3.