Task #47003
Epic #55575: Streamline JavaScript Code in the TYPO3 Backend
Replace old DynTabMenu code with jQuery/RequireJS plugin
| Status: | Rejected | Start date: | 2013-04-06 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Benjamin Mack | % Done: | 100% |
|
| Category: | - | Spent time: | - | |
| Target version: | - | |||
| TYPO3 Version: | 6.1 | Complexity: | ||
| PHP Version: | Sprint Focus: |
Description
On the JS code sprint, the task to work on the DynTabMenu to be abstracted and
cleaned is done via RequireJS + jQuery.
A completely new jQuery plugin is written that stores the current selected tab ID
in the local storage (available in IE8+) or falls back to the first tab of the menu
item.
The changes separates logic (JS) from structure (HTML), and removes
plain old JS.
Related issues
Associated revisions
[TASK] Replace DynTabMenu with jQuery/RequireJS plugin
The DynTabMenu code can be abstracted and
cleaned - done via RequireJS + jQuery.
A completely new jQuery plugin is written that stores the current
selected tab ID in the local storage (available in IE8+) or falls back
to the first tab of the menu item.
The changes separates logic (JS) from structure (HTML), and removes
plain old JS.
Resolves: #47003
Releases: master
Change-Id: Ib81606cc653ccf7d58105f463bc6a09eb742b7d5
Reviewed-on: http://review.typo3.org/19708
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
History
#1 Updated by Benjamin Mack over 2 years ago
- Tracker changed from Bug to Task
#2 Updated by Gerrit Code Review over 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19708
#3 Updated by Gerrit Code Review about 2 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19708
#4 Updated by Gerrit Code Review about 2 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19708
#5 Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/19708
#6 Updated by Gerrit Code Review over 1 year ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/19708
#7 Updated by Daniel Siepmann over 1 year ago
- Parent task set to #55575
#8 Updated by Gerrit Code Review over 1 year ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/19708
#9 Updated by Gerrit Code Review 11 months ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19708
#10 Updated by Gerrit Code Review 10 months ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19708
#11 Updated by Gerrit Code Review 9 months ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19708
#12 Updated by Gerrit Code Review 9 months ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19708
#13 Updated by Gerrit Code Review 9 months ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19708
#14 Updated by Gerrit Code Review 9 months ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19708
#15 Updated by Benjamin Mack 9 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset c362ba52cf04d4bf93a5043be7fc39c27671cbcf.
#16 Updated by Stanislas Rolland 9 months ago
- Status changed from Resolved to New
Following this change, FormEngine->dynNestedStack is incorrect. It seems that the numbering of tabs has changed. But there are also sometimes more that one element at the same level in the stack.
Therefore the RTE cannot display correctly in a tab. Most obviously, the height of the iframe is wrong as well as the width of ExtJS comboboxes. This is because browsers cannot calculate and set dimensions inside an element with display: none.
The problem does not appear outside a tab. For example, when using the full screen RTE wizard.
The problem does not appear in IREE elements, it they are not inside a tab.
The problem occurs also in flexforms that are rendered with tabs containing RTE-enabled fields.
#17 Updated by Gerrit Code Review 6 months ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36401
#18 Updated by Benjamin Mack 5 months ago
- Status changed from Under Review to Rejected
solved differently now.