Bug #47188
Fluid tries to render folders as templates partials and layouts
| Status: | Resolved | Start date: | 2013-04-13 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assigned To: | Bastian Waidelich | % Done: | 100% |
|
| Category: | View | |||
| Target version: | - | |||
| Has patch: | No | Affected Flow version: | FLOW3 1.0.0 |
Description
The file_exists check in TemplateView is true also for folders. This leads to unrendered partials with resorted paths.
Solution: add additional is_dir check
Associated revisions
[BUGFIX] Don't use folders as templates, partials and layouts
The PHP function ``file_exists()`` returns TRUE for files as well as
directories.
This change adjusts Template- and StandaloneView to use ``is_file()``
instead.
Change-Id: Ib19cce211e61aa6601d809ff9ae95347e99df0f1
Fixes: #47188
Releases: master, 2.0
[BUGFIX] Don't use folders as templates, partials and layouts
The PHP function ``file_exists()`` returns TRUE for files as well as
directories.
This change adjusts Template- and StandaloneView to use ``is_file()``
instead.
Change-Id: Ib19cce211e61aa6601d809ff9ae95347e99df0f1
Fixes: #47188
Releases: master, 2.0
History
#1 Updated by Tymoteusz Motylewski almost 2 years ago
it was fixed in the CMS Fluid
see https://review.typo3.org/#/c/19920/
(replace file_exist with is_file)
#2 Updated by Krzysztof Adamczyk almost 2 years ago
ok i can do it.
#3 Updated by Gerrit Code Review almost 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23951
#4 Updated by Gerrit Code Review almost 2 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23951
#5 Updated by Bastian Waidelich almost 2 years ago
- Category set to View
- Status changed from Under Review to Accepted
- Assigned To set to Bastian Waidelich
Thanks for the report. I'll take care
#6 Updated by Gerrit Code Review almost 2 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23968
#7 Updated by Bastian Waidelich almost 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b1041e1c0b1f38fe321096b5130ac0baf1df4e45.
#8 Updated by Gerrit Code Review over 1 year ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 2.0 of project Packages/TYPO3.Fluid has been pushed to the review server.
It is available at https://review.typo3.org/27194
#9 Updated by Bastian Waidelich over 1 year ago
- Status changed from Under Review to Resolved
Applied in changeset 2bf6363234ad0b7795b3c617c6c4136549666e96.
#10 Updated by Gerrit Code Review 10 months ago
- Status changed from Resolved to Under Review
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/23951
#11 Updated by Gerrit Code Review 10 months ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/23951
#12 Updated by Gerrit Code Review 10 months ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33195
#13 Updated by Gerrit Code Review 10 months ago
Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33196
#14 Updated by Gerrit Code Review 10 months ago
Patch set 2 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33196
#15 Updated by Bastian Waidelich 8 months ago
- Status changed from Under Review to Resolved
FYI: This has been re-opened because the TYPO3 CMS changesets referenced this ticket. But in the meantime this has been merged in all affected versions including the fluid extension