Bug #47371

If matched AOP even wraps static methods which will fail on runtime

Added by Steffen Ritter over 2 years ago. Updated over 2 years ago.

Status:Resolved Start date:2013-04-19
Priority:Must have Due date:
Assigned To:Steffen Ritter % Done:

100%

Category:AOP
Target version:TYPO3 Flow Base Distribution - 2.0
PHP Version:5.4 Complexity:
Has patch:Yes Affected Flow version:Git 2.0

Description

Runtime execution fails if a static method is wrapped with AOP code because it tries to access the instance variable $this.

Static methods have to be skipped when compiling aop proxies.


Related issues

duplicated by TYPO3.Flow - Bug #47309: Calling this in static context in cached classes Closed 2013-04-17

Associated revisions

Revision 86620ec8
Added by Steffen Ritter over 2 years ago

[BUGFIX] AOP erroneously allows to advise static methods

Fixes an issue with the AOP proxy builder which erroneously allowed to
advise static methods which resulted in a PHP fatal error as soon as
such a method was called.

Fixes: #47371
Releases: master, 2.0
Change-Id: I15817e357d98eb78de8984a78582de5cdf16064e

Revision a8e61f71
Added by Steffen Ritter over 2 years ago

[BUGFIX] AOP erroneously allows to advise static methods

Fixes an issue with the AOP proxy builder which erroneously allowed to
advise static methods which resulted in a PHP fatal error as soon as
such a method was called.

Fixes: #47371
Releases: master, 2.0
Change-Id: I15817e357d98eb78de8984a78582de5cdf16064e

Revision 41b37104
Added by Aske Ertmann over 2 years ago

[TASK] Fix spelling error related to static method advice test

This was introduced with I15817e357d98eb78de8984a78582de5cdf16064e

Change-Id: I11a456d8e79e952f655e40f792052d0aefb73efd
Related: #47371

Revision ff139888
Added by Aske Ertmann over 2 years ago

[TASK] Fix spelling error related to static method advice test

This was introduced with I15817e357d98eb78de8984a78582de5cdf16064e

Change-Id: I11a456d8e79e952f655e40f792052d0aefb73efd
Related: #47371

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/20031

#2 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20032

#3 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/20031

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20032

#5 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/20031

#6 Updated by Steffen Ritter over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF